Rule/script/scene edit: Update tag input & Refactoring #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
force-pushed
the
rule-scene-edit
branch
from
521c708
to
ed88ed6
Compare
florian-h05
pushed a commit
that referenced
this pull request
Sep 26, 2023
Closes #2086 - Adds Non-semantic tags to Items list (e.g. /settings/items/) consistently with similar list of Rules / Scripts / Pages. - Extends `getItemTypeAndMetaLabel` with relatesTo part of Semantic classification and moves it to a mixin. - Fixes incorrect calculation of vue virtual box height on Items list. - Replaces custom tag input with accordion tag input (inspired by #2078) and show number of tags (inspired by #2083). - Moves the custom tag input to `item-form.vue`, so it is available also in Model view, when creating Item from Thing etc. Also-by: Florian Hotze <[email protected]> Signed-off-by: David Kesl <[email protected]>
florian-h05
force-pushed
the
rule-scene-edit
branch
from
3fef6a9
to
f1da3a2
Compare
|
I guess that Jenkins is failing because of a dependency mismatch between openHAB core and this branch. I will rebase so that #2098 is available in the PR branch. |
florian-h05
force-pushed
the
rule-scene-edit
branch
from
f1da3a2
to
f2cb252
Compare
Job #1290: Bundle Size — 15.81MiB (+0.29%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1290 report View florian-h05:rule-scene-edit branch activity |
|
@ghys Can you please have a look at this PR? |
Signed-off-by: Florian Hotze <[email protected]>
…al-settings.vue Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
force-pushed
the
rule-scene-edit
branch
from
f2cb252
to
7c489d7
Compare
|
Sorry for not having reviewed it - you were right to merge, it's a good addition 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rule-edit-mixin.js).