Adapt movecontrol icon to bright and dark themes #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
|
This change depends on #2084 as only the SVG icon is updated. |
|
As Main UI does not adjust icon color depending on theme when "currentColor" is used in the SVG, I will update my change to not use "currentColor" and choose a "hardcoded" color that is fine in bright and dark themes. |
Related to openhab#1769 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
upd_icon_movecontrol
branch
from
34c423c
to
d97e8cd
Compare
|
@openhab/webui-maintainers : ready for review. With this change: Before this change: |
florian-h05
approved these changes
Nov 20, 2023
|
@kaikreuzer : another similar one to merge |
|
@florian-h05 Surely, you are allowed to merge as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1769
Signed-off-by: Laurent Garnier [email protected]