[BasicUI] Fix SSE reconnection to the current page #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an error in the SSE connection, the event source is now reconnected to the right sitemap page. Fix one of both problems explained in openhab#1757 Signed-off-by: Laurent Garnier <[email protected]>
|
@kaikreuzer : this bug was there probably more or less since the first day of Basic UI but because the SSE connection is working very well, I never noticed it because SSE reconnection was never required. I discovered it today because the SSE connection is now no more reliable when using Firefox and now the reconnection code is used. |
kaikreuzer
approved these changes
Jan 20, 2024
|
@kaikreuzer if you are ok, I cherry pick this fix in 4.1.x branch? |
|
@lolodomo Yes, sure, feel free! |
lolodomo
added a commit
that referenced
this pull request
Jan 21, 2024
After an error in the SSE connection, the event source is now reconnected to the right sitemap page. Fix one of both problems explained in #1757 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
added
the
patch
Ok, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an error in the SSE connection, the event source is now reconnected to the right sitemap page.
Fix one of both problems explained in #1757
Signed-off-by: Laurent Garnier [email protected]