Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

[weather] Replaced org.apache.commons.httpclient dependency with ESH HttpUtil #5294

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

cweitkamp
Copy link
Contributor

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp cweitkamp changed the title [waether] Replaced org.apache.commons.httpclient dependency with ESH HttpUtil [weather] Replaced org.apache.commons.httpclient dependency with ESH HttpUtil Sep 2, 2017
@kaikreuzer
Copy link
Member

Just to note: This won't have any real effect, since org.openhab.io.net.http.HttpUtil is still using the Apache HTTP client. This is done to keep full backward compatibility for all 1.x add-ons.

@cweitkamp
Copy link
Contributor Author

I see. Wasn't aware of that. Thanks for mentioning it. So this is only a minor code clean up.

Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@9037568 9037568 added this to the 1.11.0 milestone Sep 19, 2017
@9037568
Copy link
Contributor

9037568 commented Sep 27, 2017

Thanks, @cweitkamp !

@9037568 9037568 merged commit bc94d08 into openhab:master Sep 27, 2017
@cweitkamp cweitkamp deleted the feature-weather-httputil branch September 27, 2017 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants