This repository has been archived by the owner on May 23, 2019. It is now read-only.
Improve the initial rendering of several widgets #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- slider: Wait for the first event to display the widget (this hack seems to fix a long-standing display glitch e.g. when switching dashboards); - chart: attempt to get rid the the initial data series animations; - colorpicker: remove the initial "flickering"; - template: send an update event after opening a modal dialog Signed-off-by: Yannick Schaus <[email protected]>
|
This change causes the slider to never appear if it is attached to a number item that has a state of NULL. I believe this is due to the condition "!isNaN(value)" within the function "updateValue". |
ghys
added a commit
to ghys/habpanel
that referenced
this pull request
Sep 14, 2017
Regression introduced and reported in openhab#214. (+ remove leftover in custom header markup) Signed-off-by: Yannick Schaus <[email protected]>
ghys
added a commit
that referenced
this pull request
Sep 14, 2017
Regression introduced and reported in #214. (+ remove leftover in custom header markup) Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to fix a long-standing display glitch e.g. when switching dashboards);
Signed-off-by: Yannick Schaus [email protected]