Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ReturnToService line in /etc/slurm/slurm.conf #1994

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

mikerenfro
Copy link
Contributor

Fixes #1991

Copy link

github-actions bot commented Jul 4, 2024

Test Results

14 files   -  20  14 suites   - 20   6s ⏱️ - 3m 0s
41 tests  - 184  41 ✅  - 184  0 💤 ±0  0 ❌ ±0 
54 runs   - 184  54 ✅  - 184  0 💤 ±0  0 ❌ ±0 

Results for commit a467269. ± Comparison against base commit 969681a.

This pull request removes 184 tests.
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C binary includes expected Score-P instrumenter symbols (/gnu13/mpich)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C binary includes expected Score-P instrumenter symbols (/gnu13/openmpi5)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C binary includes expected Score-P instrumenter symbols (/intel/mpich)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C binary includes expected Score-P instrumenter symbols (/intel/openmpi5)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C++ binary includes expected Score-P instrumenter symbols (/gnu13/mpich)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C++ binary includes expected Score-P instrumenter symbols (/gnu13/openmpi5)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C++ binary includes expected Score-P instrumenter symbols (/intel/mpich)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) C++ binary includes expected Score-P instrumenter symbols (/intel/openmpi5)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) Fortran binary includes expected Score-P instrumenter symbols (/gnu13/mpich)
instrumenter_test ‑ [perf-tools/Score-P] Hybrid (MPI+OpenMP) Fortran binary includes expected Score-P instrumenter symbols (/gnu13/openmpi5)
…

@adrianreber
Copy link
Member

Unfortunately our CI is not clever enough to detect that your change means that a rebuild of slurm is required to test the PR. Test builds in CI are only triggered if the actual spec file is changed. The changed patch does not trigger a rebuild.

Trying it out locally your PR fails building. Following change on top helps:

-@@ -149,5 +149,22 @@
+@@ -149,5 +149,20 @@

Also, we require patches to be signed-off-by as described in https://github.com/openhpc/ohpc/blob/3.x/CONTRIBUTING.md

Fixing the patch with what I posted and adding the correct sign off should make this ready to be merged.

Copy link

github-actions bot commented Aug 9, 2024

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate ReturnToService line in /etc/slurm/slurm.conf?
2 participants