Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score-P & Scalasca: Add minor fixes #2017

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

Thyre
Copy link
Contributor

@Thyre Thyre commented Sep 18, 2024

Add two minor fixes to Score-P & Scalasca, which were partially already merged in other build systems.

Score-P:

GCC 14 has changed some things on GMP, which caused our GCC plug-in check to fail. We fixed this in the Score-P 9.0 development cycle by updating our "fake" header. This commit backports these changes to Score-P 8.4, so that the GCC plug-in continues to work. This patch is already merged in Fedora for example (see here).

Scalasca:

Add a small patch which fixes a typo in configure. This can cause tests to during configure to fail, as all tests after the OpenMP detection will be checked for any output on stdout and stderr. A PR for this fix exists for Fedora & EasyBuild, with our internal JSC EasyBuild having this patch for quite some while already.

Copy link

github-actions bot commented Sep 18, 2024

Test Results

 34 files  + 34   34 suites  +34   3m 9s ⏱️ + 3m 9s
225 tests +225  225 ✅ +225  0 💤 ±0  0 ❌ ±0 
238 runs  +238  238 ✅ +238  0 💤 ±0  0 ❌ ±0 

Results for commit 7262301. ± Comparison against base commit 8fea65d.

♻️ This comment has been updated with latest results.

@adrianreber
Copy link
Member

Thanks. You don't need to change the release from 1 to 2. This is done automatically by the build system. Please undo those changes.

GCC 14 requires a patch to use the GCC plug-in correctly.
This patch is backported from the Score-P 9.0 development cycle.

Signed-off-by: Jan André Reuter <[email protected]>
@adrianreber adrianreber merged commit d28c134 into openhpc:3.x Sep 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants