Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Hierarchical Wiring in cv32e40p_tb_subsystem.sv Line **157** #843

Closed
DerakhshanAli opened this issue Aug 3, 2023 · 4 comments
Closed
Assignees
Labels
Type:Enhancement For feature requests and enhancements

Comments

@DerakhshanAli
Copy link

Bug Title:
Wrong Hierarchical Wiring
in cv32e40p_tb_subsystem.sv Line 157
. . .
Line 157: .pc_core_id_i(wrapper_i.core_i.pc_id),
. . .

I think The  wrapper_i.core_i.pc_id  must change into a top_i.core_i.pc_id

Component:RTL:
cv32e40p_tb_subsystem.sv

cv32e40p-cv32e40p_v1.3.2.

@davideschiavone
Copy link
Contributor

Hello @DerakhshanAli and thanks for sharing this issue with us.

I do not see this issue here https://github.com/openhwgroup/cv32e40p/blob/master/bhv/cv32e40p_tb_wrapper.sv#L157

can you point me where is there problem? thanks

@davideschiavone
Copy link
Contributor

ah sorry I looked at the wrong file, the issue is here https://github.com/openhwgroup/cv32e40p/blob/master/example_tb/core/cv32e40p_tb_subsystem.sv#L157, agree - @pascalgouedo , can we fix this in the next release?

@davideschiavone davideschiavone added the Type:Enhancement For feature requests and enhancements label Aug 11, 2023
@DerakhshanAli
Copy link
Author

Glad to contribute.

In this Directory:
cv32e40p_v1.3.2\example_tb\core

cv32e40p_tb_subsystem.sv Line 157
. . .
Line 157: .pc_core_id_i(wrapper_i.core_i.pc_id),

I encountered this issue when I wanted to Run Core simulation according to Makefile in cv32e40p_v1.3.2\example_tb\core directory with [make custom-vsim-run-gui] Command.

pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 16, 2023
Signed-off-by: Pascal Gouedo <[email protected]>
davideschiavone added a commit that referenced this issue Aug 16, 2023
@pascalgouedo
Copy link

Fixed with #851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

No branches or pull requests

3 participants