Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded path to the wrong position #1572

Closed
rejsys opened this issue Oct 25, 2023 · 3 comments
Closed

Hardcoded path to the wrong position #1572

rejsys opened this issue Oct 25, 2023 · 3 comments
Assignees
@valentinThomazic
Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system Type:Item-of-task This issue is an item of a larger task.

Comments

@rejsys
Copy link

rejsys commented Oct 25, 2023

Hello,

the hardcoded path shown here is pointing to the wrong position:

cva6/Makefile

Line 55 in 53d3880

VL_INC_DIR := $(VERILATOR_INSTALL_DIR)/share/verilator/include

This creates an error if the flag TRACE_FAST=1 is set in make verilator:

cva6/Makefile

Line 563 in 53d3880

$(if $(TRACE_FAST), --trace $(VL_INC_DIR)/verilated_vcd_c.cpp) \

@JeanRochCoulon JeanRochCoulon self-assigned this Oct 26, 2023
@JeanRochCoulon JeanRochCoulon added the Type:Item-of-task This issue is an item of a larger task. label Oct 26, 2023
@JeanRochCoulon
Copy link
Contributor

Related to #1569

@JeanRochCoulon JeanRochCoulon added Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system labels Oct 26, 2023
@valentinThomazic valentinThomazic mentioned this issue Dec 8, 2023
Merged
@valentinThomazic
Copy link
Contributor

Hey @rejsys, #1686 adressing this issue has been merged. If you are ok with the changes, please close your issue.

@rejsys
Copy link
Author

rejsys commented Dec 11, 2023

fixed here: #1686

@rejsys rejsys closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinThomazic valentinThomazic

Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system Type:Item-of-task This issue is an item of a larger task.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeanRochCoulon @rejsys @valentinThomazic