Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use cva6.py to simulate cva6 and clean-up env setup #1569

Closed
1 task done
JeanRochCoulon opened this issue Oct 24, 2023 · 4 comments
Closed
1 task done

[TASK] Use cva6.py to simulate cva6 and clean-up env setup #1569

JeanRochCoulon opened this issue Oct 24, 2023 · 4 comments
Assignees
Labels
Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Type:Task Project related task

Comments

@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Oct 24, 2023

Is there an existing CVA6 task for this?

  • I have searched the existing task issues

Task Description

Support only cva6.py commands to simulate cva6.
Today two set of commands are available to simulate cva6: cva6.py coming from riscv-dv repo and "make verilate" supported by Makefile. To reduce confusion for newcomers and increase the simulation env quality, we will support only the cva6.py commands and remove the "make verilate" commands from Makefile.

Required Changes

Move Github action CI to cva6.py commands

Current Status

Today two set of commands are available to simulate cva6

Risks

Users using "make verilate" should change their habits.

Prerequisites

Before removing make verilate,

  • GitHub actions CI must be move to cva6.py commands and
  • we must confirm all current features are supported by cva6.py

KPI (KEY Performance Indicators)

No response

Description of Done

"make verilate" removed from Makefile

Associated PRs

No response

@JeanRochCoulon JeanRochCoulon self-assigned this Oct 24, 2023
@JeanRochCoulon JeanRochCoulon added Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Type:Task Project related task labels Oct 24, 2023
@JeanRochCoulon JeanRochCoulon changed the title [TASK] Support only cva6.py commands to simulate cva6 [TASK] Use cba6.py to simulate cva6 Oct 24, 2023
@JeanRochCoulon JeanRochCoulon changed the title [TASK] Use cba6.py to simulate cva6 [TASK] Use cva6.py to simulate cva6 and clean-up env setup Oct 24, 2023
@JeanRochCoulon
Copy link
Contributor Author

@valentinThomazic

@valentinThomazic
Copy link
Contributor

Usage of the proxy kernel which was still using Makefile targets to run simulation has been dropped.
See : #1663
This means that, at this point, all simulation features should be supported by cva.py

@JeanRochCoulon
Copy link
Contributor Author

GitHub Actions uses "make verilate" to simulate. A possible action would be to switch this CI from "make verilate" to "cva6.py". The ideal action would be to adapt Github Actions to "cva6.py" and to remove the relative "make verilate" commands from the Makefile. I wonder what is the plan for you @MarioOpenHWGroup and @MikeOpenHWGroup ?

@JeanRochCoulon
Copy link
Contributor Author

Good job. The task is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Type:Task Project related task
Projects
Status: Done - Ready for Review
Development

No branches or pull requests

2 participants