[rtl] Change how we record debug causes #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideschiavone
changed the title
| // The decision to enter debug_mode and the write of the cause to DCSR happen | ||
| // in seperate steps within the FSM. Hence, there are a small number of cycles | ||
| // where a change in external stimulus can cause the cause to be recorded incorrectly. | ||
| assign debug_cause_d = trigger_match_i ? DBG_CAUSE_TRIGGER : |
There was a problem hiding this comment.
isn't this a bigger change than the title states? Seems to also change the priority of debug causes
There was a problem hiding this comment.
true but I copied the commit they used - feel free to suggest a new name
|
@christian-herber-nxp , what is the status of this PR? |
|
i did not yet have the chance to review how this maps to the debug spec as this is a functional change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.