Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast: fix conversion to signed integer #97

Merged

Conversation

gregdavill
Copy link
Contributor

Correctly convert signed integers of negative max-magnitude value without erroneously flagging an overflow condition

Issue: #83

Correctly convert signed integers of negative max-magnitude value
without erroneously flagging an overflow condition

issue: openhwgroup#83

Signed-off-by: Greg Davill <[email protected]>
Copy link

@pascalgouedo pascalgouedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing Formal Verification check as well.

@pascalgouedo pascalgouedo merged commit b45a186 into openhwgroup:develop Aug 2, 2023
@gregdavill gregdavill deleted the cast_overflow_flag_fix branch August 2, 2023 10:16
@pascalgouedo pascalgouedo mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants