Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix githook and set openkf build images ci #173

Merged
merged 2 commits into from
Sep 6, 2023
Merged

feat: fix githook and set openkf build images ci #173

merged 2 commits into from
Sep 6, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Sep 6, 2023

Signed-off-by: Xinwei Xiong(cubxxw-openim) [email protected]

🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Resolves #36, resolves #171

📝 Special notes for your reviewer:

🎯 Describe how to verify it

 make githook

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>

feat: add openkf release and build image fix

Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>

feat: add aliyun npm agent

Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>

feat: add openim im ctl

Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>

feat: add openim im ctl

Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 6, 2023
@cubxxw cubxxw temporarily deployed to openkf September 6, 2023 06:23 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openkf September 6, 2023 06:23 — with GitHub Actions Inactive
@@ -17,6 +17,7 @@ require (
github.com/rifflock/lfshook v0.0.0-20180920164130-b9218ef580f5
github.com/shomali11/slacker v1.4.1
github.com/sirupsen/logrus v1.9.3
github.com/slack-go/slack v0.12.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose? to bump version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for slack plugin in OpenKF.

Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cubxxw cubxxw merged commit e0fd186 into openimsdk:main Sep 6, 2023
16 of 18 checks passed
@cubxxw cubxxw deleted the build/images branch September 6, 2023 09:51
@openimsdk openimsdk locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants