-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix githook and set openkf build images ci #173
Conversation
Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]> feat: add openkf release and build image fix Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]> feat: add aliyun npm agent Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]> feat: add openim im ctl Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]> feat: add openim im ctl Signed-off-by: Xinwei Xiong(cubxxw-openim) <[email protected]>
@@ -17,6 +17,7 @@ require ( | |||
github.com/rifflock/lfshook v0.0.0-20180920164130-b9218ef580f5 | |||
github.com/shomali11/slacker v1.4.1 | |||
github.com/sirupsen/logrus v1.9.3 | |||
github.com/slack-go/slack v0.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this on purpose? to bump version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used for slack plugin in OpenKF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Xinwei Xiong(cubxxw-openim) [email protected]
🔍 What type of PR is this?
/kind documentation
/kind feature
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Resolves #36, resolves #171
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: