feat: add prettier and eslint (#18) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 27, 2023 19:55
MC-kanon
requested review from
cubxxw,
kubbot,
IRONICBo and
PolarishT
as code owners
pull-request-size
bot
added
the
size/L
cubxxw
reviewed
Jun 28, 2023
web/.prettierrc.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| module.exports = { | |||
| printWidth: 80, // 每行代码长度（默认80） | |||
There was a problem hiding this comment.
Maybe we should use English for the comments
2 tasks
|
lgtm |
PolarishT
reviewed
Jun 28, 2023
| @@ -16,15 +16,15 @@ | |||
| --> | |||
PolarishT
reviewed
Jun 28, 2023
| "@element-plus/icons-vue": "^2.1.0", | ||
| "axios": "^1.4.0", | ||
| "echarts": "^5.4.2", | ||
| "element-plus": "^2.3.7", |
There was a problem hiding this comment.
suggest to use acro-design or Tdesign
element-plus is up to date
PolarishT
reviewed
Jun 28, 2023
web/src/main.js
Outdated
There was a problem hiding this comment.
what about to use alova https://alova.js.org/zh-CN/ maybe more easier and lightful
|
Thanks for CR. |
|
lgtm |
IRONICBo
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add prettier and eslint #18