8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

[roberttoyonaga]

This is a backport of openjdk/jdk@65be5e0

This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.

This should help resolve some test failures for Adoptium (see adoptium/aqa-tests#2766)

Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.

---

Progress

• JDK-8305931 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none" (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2686/head:pull/2686
$ git checkout pull/2686

Update a local copy of the PR:
$ git checkout pull/2686
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2686

View PR using the GUI difftool:
$ git pr show -t 2686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2686.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 137a8b9: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
• d42634b: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
• 9363095: 8328194: Add a test to check default rendering engine
• 81f2413: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
• f7d0522: 8315889: Open source several Swing HTMLDocument related tests
• 1e1688a: 8294137: Review running times of java.math tests
• d8b297f: 8306067: Open source AWT Graphics,GridBagLayout related tests
• 9df5688: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• f29aa4d: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• ac43e68: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
• ... and 48 more: https://git.openjdk.org/jdk11u-dev/compare/6808c5c89d1e30f481ebe444f93175232bcd30e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (cad36193)

[roberttoyonaga]

/approval request for the clean backport of a JFR test fix for TestJcmdDumpPathToGCRoots. This only affects test code so should be a low risk.

[openjdk]

@roberttoyonaga
8305931: The approval request has been created successfully.

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version cad3619) is now ready to be sponsored by a Committer.

[jerboaa]

/integrate

[openjdk]

@jerboaa Only the author (@roberttoyonaga) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[jerboaa]

/sponsor

[openjdk]

Going to push as commit cabaf74.
Since your change was applied there have been 58 commits pushed to the master branch:

• 137a8b9: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
• d42634b: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
• 9363095: 8328194: Add a test to check default rendering engine
• 81f2413: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
• f7d0522: 8315889: Open source several Swing HTMLDocument related tests
• 1e1688a: 8294137: Review running times of java.math tests
• d8b297f: 8306067: Open source AWT Graphics,GridBagLayout related tests
• 9df5688: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• f29aa4d: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• ac43e68: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
• ... and 48 more: https://git.openjdk.org/jdk11u-dev/compare/6808c5c89d1e30f481ebe444f93175232bcd30e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @roberttoyonaga Pushed as commit cabaf74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.