Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339560: Unaddressed comments during code review of JDK-8337664 #151

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Oct 10, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339560 needs maintainer approval

Issue

  • JDK-8339560: Unaddressed comments during code review of JDK-8337664 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jdk23u.git pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/151.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 95d3e9d199600bac0284f9151b99aef152e027ac 8339560: Unaddressed comments during code review of JDK-8337664 Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 10, 2024
@rgangadhar rgangadhar marked this pull request as draft October 10, 2024 09:26
@openjdk openjdk bot added approval and removed approval labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant