Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341757: Field layout computation allowing atomic and nullable flattening #1275

Draft
wants to merge 2 commits into
base: lworld
Choose a base branch
from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Oct 11, 2024

Initial implementation of fields layouts in order to support heap flattening with JEP 401 model.
The patch includes the generation of two new flat fields layouts: atomic and nullable.
The patch also includes the support in the interpreter (through the access API) to access the new layouts while respecting the new semantic (on x86_64 and aarch64).
Some areas do not support the new layouts yet, like JITs, Unsafe and arrays.

There's no automatic tests yet, but considering the impact those new layouts will have on the JVM, the priority was to make this code available to all developers as soon as possible. Automatic tests will be added in a following CR.

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8341757: Field layout computation allowing atomic and nullable flattening (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1275/head:pull/1275
$ git checkout pull/1275

Update a local copy of the PR:
$ git checkout pull/1275
$ git pull https://git.openjdk.org/valhalla.git pull/1275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1275

View PR using the GUI difftool:
$ git pr show -t 1275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2024

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 11, 2024

@fparain this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout nullable_flat_2
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant