Always report bibtex entries in DOI checker #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the sloppy pull, someone is using my computer rn but I can fix once theyre done |
xuanxu
approved these changes
Mar 6, 2024
|
Thanks @sneakers-the-rat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all bibliography entries have DOIs, and that's fine! But it can be confusing when there are bibliography entries and they don't show up in the DOI checker - what happened to them? It is semantically correct to say that DOIs are "missing" for entries where a DOI is not provided and one can't be found when querying crossref, and also for entries where a title is not provided, both of which are currently silently dropped by the DOI checker.
This PR adds
elsestatements to the two unfinished legs of thecheck_doismethod and updates the spec to match. Not sure if i wrote those test cases correctly, my bad if not.