Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SSMSE: An R package for Management Strategy Evaluation with Stock Synthesis Operating Models #4536

Closed
editorialbot opened this issue Jul 1, 2022 · 69 comments
Assignees
Labels
pre-review R TeX Track: 6 (ESE) Earth Sciences and Ecology waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 1, 2022

Submitting author: @k-doering-NOAA (Kathryn Doering)
Repository: https://github.com/nmfs-fish-tools/ssmse
Branch with paper.md (empty if default branch):
Version: v0.2.6
Editor: @sbenthall
Reviewers: @seananderson, @quang-huynh
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9af77892379058580aced7199f3dc6dd"><img src="https://joss.theoj.org/papers/9af77892379058580aced7199f3dc6dd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9af77892379058580aced7199f3dc6dd/status.svg)](https://joss.theoj.org/papers/9af77892379058580aced7199f3dc6dd)

Author instructions

Thanks for submitting your paper to JOSS @k-doering-NOAA. Currently, there isn't a JOSS editor assigned to your paper.

@k-doering-NOAA if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (917.0 files/s, 206719.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               58            566           2362           8736
Scheme                          19             18              0           7830
Markdown                         5            176              0            994
Rmd                              8            336            612            539
CSS                              1             66              1            275
TeX                              1            270              0            274
YAML                            11             17             19            204
HTML                             1             58              8             83
-------------------------------------------------------------------------------
SUM:                           104           1507           3002          18935
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 3415

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0092725 is OK
- 10.1126/science.1149016 is OK
- 10.7755/TMSPO.183 is OK
- 10.1139/f03-109 is OK
- 10.1016/j.fishres.2018.12.014 is OK
- 10.1016/j.fishres.2012.10.012 is OK
- 10.2760/18924 is OK
- 10.1111/faf.12104 is OK
- 10.1006/jmsc.2000.0737 is OK
- 10.1139/cjfas-2020-0257 is OK
- 10.1111/j.1467-2979.2011.00417.x is OK
- 10.1016/j.fishres.2021.105924 is OK

MISSING DOIs

- 10.1002/fsh.10131 may be a valid DOI for title: Handle with care: establishing catch limits for fish stocks experiencing episodic natural mortality events
- 10.1016/j.fishres.2020.105725 may be a valid DOI for title: An integrated tagging and catch-curve model reveals high and seasonally-varying natural mortality for a fish population at low stock biomass
- 10.1016/j.fishres.2020.105854 may be a valid DOI for title: Spatial population dynamics of eastern oyster in the Chesapeake Bay, Maryland
- 10.1016/j.fishres.2022.106229 may be a valid DOI for title: Playing the detective: Using multispecies approaches to estimate natural mortality rates
- 10.1016/j.fishres.2021.106180 may be a valid DOI for title: Indexing starvation mortality to assess its role in the population regulation of Northern cod
- 10.1111/faf.12480 may be a valid DOI for title: Operating model design in tuna Regional Fishery Management Organizations: Current practice, issues and implications

INVALID DOIs

- 10.1577/1548-8446(2006)31\[590:TCFIE\]2.0.CO;2 URL is INVALID

@editorialbot
Copy link
Collaborator Author

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Jul 1, 2022

@k-doering-NOAA thanks for this submission. I am a JOSS AEiC and here to help process initial steps.

  • Can you check those potentially missing/invalid DOIs? ☝️ You can check the references gain by calling @editorialbot check references.

  • There is a paper compilation error:

Problem with ORCID (00000-0002-0396-7044) for Kathryn Doering. ORCID looks to be the wrong length (Theoj::Error)

Looks like it should have 4 zeros at the start, not 5: https://orcid.org/0000-0002-0396-7044
Can you fix this and try to compile the paper again? You can call @editorialbot generate pdf here.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 1, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@k-doering-NOAA I have just added the waitlisted label here because all our editors in this domain are currently handling many other submissions. We will assign a handling editor as soon as one becomes available.

@Kevin-Mattheus-Moerman
Copy link
Member

@KristinaRiemer do you think you could edit this one once you are available?

@danielskatz
Copy link

👋 @k-doering-NOAA - note that your paper does not compile. As @Kevin-Mattheus-Moerman says, you at least need to remove the extra 0 in an ORCID. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@k-doering-NOAA
Copy link

Thank you @danielskatz and others - I will make changes to the ORCID, check the DOIs, and figure out why the paper isn't compiling within the next few days!

@k-doering-NOAA
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0092725 is OK
- 10.1126/science.1149016 is OK
- 10.1002/fsh.10131 is OK
- 10.1016/j.fishres.2020.105725 is OK
- 10.7755/TMSPO.183 is OK
- 10.1016/j.fishres.2020.105854 is OK
- 10.1139/f03-109 is OK
- 10.1016/j.fishres.2018.12.014 is OK
- 10.1016/j.fishres.2012.10.012 is OK
- 10.2760/18924 is OK
- 10.1016/j.fishres.2022.106229 is OK
- 10.1111/faf.12104 is OK
- 10.1016/j.fishres.2021.106180 is OK
- 10.1006/jmsc.2000.0737 is OK
- 10.1139/cjfas-2020-0257 is OK
- 10.1111/j.1467-2979.2011.00417.x is OK
- 10.1111/faf.12480 is OK
- 10.1016/j.fishres.2021.105924 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1577/1548-8446(2006)31\[590:TCFIE\]2.0.CO;2 URL is INVALID

@k-doering-NOAA
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0092725 is OK
- 10.1126/science.1149016 is OK
- 10.1002/fsh.10131 is OK
- 10.1016/j.fishres.2020.105725 is OK
- 10.7755/TMSPO.183 is OK
- 10.1016/j.fishres.2020.105854 is OK
- 10.1139/f03-109 is OK
- 10.1016/j.fishres.2018.12.014 is OK
- 10.1016/j.fishres.2012.10.012 is OK
- 10.2760/18924 is OK
- 10.1016/j.fishres.2022.106229 is OK
- 10.1111/faf.12104 is OK
- 10.1016/j.fishres.2021.106180 is OK
- 10.1006/jmsc.2000.0737 is OK
- 10.1139/cjfas-2020-0257 is OK
- 10.1111/j.1467-2979.2011.00417.x is OK
- 10.1111/faf.12480 is OK
- 10.1016/j.fishres.2021.105924 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1577/1548-8446(2006)31[590:TCFIE]2.0.CO;2 URL is INVALID

@k-doering-NOAA
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@k-doering-NOAA
Copy link

@Kevin-Mattheus-Moerman and @danielskatz, I fixed most of the DOIs and the paper now compiles with removing 1 0 from the ORCID.

I still am not able to resolve the invalid DOI, I think it has something to do with the [] in the DOI - I thought these characters needed to be esacaped (e.g., \[), but that didn't work, nor did not escaping them ([). The following link works: https://doi.org/10.1577/1548-8446(2006)31[590:TCFIE]2.0.CO;2 . Any suggestions on how I should change the DOI in the .bib file?

@k-doering-NOAA
Copy link

Potential reviewers: Ecosantos hvoltbb EDiLD

@KristinaRiemer
Copy link

@Kevin-Mattheus-Moerman my current submissions are going a bit slowly, but I can definitely edit this submission once one of those are done!

@k-doering-NOAA
Copy link

@danielskatz and @Kevin-Mattheus-Moerman, just wondering if either of you had a suggestion of what to do about the one DOI I cannot figure out how to make valid? (see previous post in thread)

@lorenzo-rovigatti
Copy link

Maybe you could try encoding the offending part... doing that gives 10.1577/1548-8446%282006%2931%5B590%3ATCFIE%5D2.0.CO%3B2

@k-doering-NOAA
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0092725 is OK
- 10.1126/science.1149016 is OK
- 10.1002/fsh.10131 is OK
- 10.1016/j.fishres.2020.105725 is OK
- 10.7755/TMSPO.183 is OK
- 10.1016/j.fishres.2020.105854 is OK
- 10.1139/f03-109 is OK
- 10.1016/j.fishres.2018.12.014 is OK
- 10.1016/j.fishres.2012.10.012 is OK
- 10.2760/18924 is OK
- 10.1016/j.fishres.2022.106229 is OK
- 10.1111/faf.12104 is OK
- 10.1016/j.fishres.2021.106180 is OK
- 10.1006/jmsc.2000.0737 is OK
- 10.1139/cjfas-2020-0257 is OK
- 10.1111/j.1467-2979.2011.00417.x is OK
- 10.1111/faf.12480 is OK
- 10.1016/j.fishres.2021.105924 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1577/1548-844628200629315B5903ATCFIE5D2.0.CO3B2 is INVALID

@k-doering-NOAA
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0092725 is OK
- 10.1126/science.1149016 is OK
- 10.1002/fsh.10131 is OK
- 10.1016/j.fishres.2020.105725 is OK
- 10.7755/TMSPO.183 is OK
- 10.1016/j.fishres.2020.105854 is OK
- 10.1139/f03-109 is OK
- 10.1016/j.fishres.2018.12.014 is OK
- 10.1016/j.fishres.2012.10.012 is OK
- 10.2760/18924 is OK
- 10.1016/j.fishres.2022.106229 is OK
- 10.1111/faf.12104 is OK
- 10.1016/j.fishres.2021.106180 is OK
- 10.1006/jmsc.2000.0737 is OK
- 10.1139/cjfas-2020-0257 is OK
- 10.1111/j.1467-2979.2011.00417.x is OK
- 10.1111/faf.12480 is OK
- 10.1016/j.fishres.2021.105924 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1577/1548-844628200629315B5903ATCFIE5D2.0.CO3B2 is INVALID

@k-doering-NOAA
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Assigned! @sbenthall is now the editor

@sbenthall
Copy link

@Ecosantos Would you be able to review this submission?

@Ecosantos
Copy link

@sbenthall, Thanks for the invitation but, I am not really sure if I can review this submission. Fishery stock assessment has some particular nuances out of my expertise.

I am happy to review anything related to population assessment of non-fishery stocks in the future.

@sbenthall
Copy link

@HVoltBb Would you be able to review this submission to JOSS?

@sbenthall
Copy link

@Edild Would you please be able to review this submission to JOSS?

@eduardszoecs
Copy link

I am on vacation the next 3 weeks and cannot make it.

@sbenthall
Copy link

@tkchafin Would you be able to review this submission?

@sbenthall
Copy link

@jsta would you be able to review this submission?

@tkchafin
Copy link

tkchafin commented Sep 1, 2022

Sorry, I can't review this one.

@jsta
Copy link
Member

jsta commented Sep 5, 2022

I can't review either.

@sbenthall
Copy link

@r-barnes Would you please be able to review this submission?

@sbenthall
Copy link

@molgor Would you please be able to review this submission?

@sbenthall
Copy link

@tretherington Would you be able to review this submission?

@sbenthall
Copy link

@pboesu Would you be able to review this submission?

@pboesu
Copy link

pboesu commented Oct 1, 2022

@sbenthall Unfortunately I am tied up with editorial duties elsewhere. Sorry!

@tretherington
Copy link

@sbenthall sorry, I'm too busy right now to commit ☹️

@sbenthall
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

I can't add that reviewer: seananderson is not a username

@sbenthall
Copy link

@editorialbot add @seananderson as reviewer

@editorialbot
Copy link
Collaborator Author

@seananderson added to the reviewers list!

@sbenthall
Copy link

Thanks @seananderson for agreeing to be a reviewer!

@k-doering-NOAA
Copy link

Thank you @seananderson!

@sbenthall
Copy link

@editorialbot add @quang-huynh as reviewer

@editorialbot
Copy link
Collaborator Author

@quang-huynh added to the reviewers list!

@sbenthall
Copy link

Thank you @quang-huynh for agreeing to be a reviewer!

We have enough reviewers so now we can begin the review process.

@sbenthall
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R TeX Track: 6 (ESE) Earth Sciences and Ecology waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests