[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

editorialbot · 2024-06-08T12:45:23Z

Submitting author: @kyleaoman (Kyle Oman)
Repository: https://github.com/kyleaoman/martini
Branch with paper.md (empty if default branch): joss-paper
Version: v2.0.12
Editor: @dfm
Reviewers: @dfm
Archive: 10.5281/zenodo.11198185

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09"><img src="https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09/status.svg)](https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dfm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@dfm, please create your checklist typing: @editorialbot generate my checklist

The text was updated successfully, but these errors were encountered:

editorialbot · 2024-06-08T12:45:26Z

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot · 2024-06-08T12:45:47Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stu2058 is OK
- 10.1093/mnras/stu1536 is OK
- 10.1086/112164 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1086/322526 is OK
- 10.22323/1.215.0129 is OK
- 10.1093/mnras/stw1876 is OK
- 10.1093/mnras/stv2674 is OK
- 10.1093/mnras/stac1213 is OK
- 10.1093/mnras/stad549 is OK
- 10.48550/arXiv.2401.11878 is OK
- 10.1093/mnras/stac2684 is OK
- 10.1093/mnras/stab2279 is OK
- 10.1093/mnras/stz2069 is OK
- 10.3847/2041-8213/ab40c7 is OK
- 10.1093/mnras/staa1256 is OK
- 10.1093/mnras/staa1072 is OK
- 10.1093/mnras/sty2687 is OK
- 10.48550/arXiv.2311.10657 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot · 2024-06-08T12:45:48Z

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (1118.2 files/s, 185058.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          43           1323           3116           5872
Markdown                         6            162              0            694
Jupyter Notebook                 3              0           1944            452
reStructuredText                29            389            587            338
TeX                              1             24              3            309
SVG                              2              2              2            223
YAML                             4             14              9            129
TOML                             1              3              0             46
JSON                             1              0              0             24
HTML                             2              1              0             17
CSS                              1              3              0             13
make                             1              4              7              9
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            95           1925           5668           8129
-------------------------------------------------------------------------------

Commit count by author:

   471	Kyle Oman
   206	K.A. Oman
     2	kyleaoman

editorialbot · 2024-06-08T12:45:52Z

Paper file info:

📄 Wordcount for paper.md is 1114

✅ The paper includes a Statement of need section

editorialbot · 2024-06-08T12:45:54Z

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

dfm · 2024-06-08T12:46:47Z

Cross-linking with pyOpenSci submission here: pyOpenSci/software-submission#164

editorialbot · 2024-06-08T12:46:54Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

dfm · 2024-06-08T12:47:08Z

@editorialbot set v2.0.12 as version

editorialbot · 2024-06-08T12:47:10Z

Done! version is now v2.0.12

dfm · 2024-06-08T12:47:36Z

@editorialbot set 10.5281/zenodo.11198185 as archive

editorialbot · 2024-06-08T12:47:38Z

Done! archive is now 10.5281/zenodo.11198185

dfm · 2024-06-08T12:49:06Z

@editorialbot recommend-accept

editorialbot · 2024-06-08T12:49:08Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-06-08T12:49:23Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stu2058 is OK
- 10.1093/mnras/stu1536 is OK
- 10.1086/112164 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1086/322526 is OK
- 10.22323/1.215.0129 is OK
- 10.1093/mnras/stw1876 is OK
- 10.1093/mnras/stv2674 is OK
- 10.1093/mnras/stac1213 is OK
- 10.1093/mnras/stad549 is OK
- 10.48550/arXiv.2401.11878 is OK
- 10.1093/mnras/stac2684 is OK
- 10.1093/mnras/stab2279 is OK
- 10.1093/mnras/stz2069 is OK
- 10.3847/2041-8213/ab40c7 is OK
- 10.1093/mnras/staa1256 is OK
- 10.1093/mnras/staa1072 is OK
- 10.1093/mnras/sty2687 is OK
- 10.48550/arXiv.2311.10657 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot · 2024-06-08T12:50:50Z

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5468, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm · 2024-06-08T12:53:04Z

@editorialbot accept

editorialbot · 2024-06-08T12:53:06Z

Doing it live! Attempting automated processing of paper acceptance...

kyleaoman · 2024-06-08T12:56:39Z

@dfm that was fast 😂

editorialbot · 2024-06-08T12:59:45Z

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Oman
  given-names: Kyle A.
  orcid: "https://orcid.org/0000-0001-9857-7788"
contact:
- family-names: Oman
  given-names: Kyle A.
  orcid: "https://orcid.org/0000-0001-9857-7788"
doi: 10.5281/zenodo.11198185
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Oman
    given-names: Kyle A.
    orcid: "https://orcid.org/0000-0001-9857-7788"
  date-published: 2024-06-08
  doi: 10.21105/joss.06860
  issn: 2475-9066
  issue: 98
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6860
  title: "MARTINI: Mock Array Radio Telescope Interferometry of the
    Neutral ISM"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06860"
  volume: 9
title: "MARTINI: Mock Array Radio Telescope Interferometry of the
  Neutral ISM"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot · 2024-06-08T12:59:48Z

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot · 2024-06-08T12:59:48Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06860 joss-papers#5469
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06860
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm · 2024-06-08T13:01:20Z

@kyleaoman – your paper is now accepted and published in JOSS ⚡🚀💥

We call the pyOpenSci review process "streamlined" for a reason! 😄

editorialbot · 2024-06-08T13:01:22Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06860/status.svg)](https://doi.org/10.21105/joss.06860)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06860">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06860/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06860/status.svg
   :target: https://doi.org/10.21105/joss.06860

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kyleaoman · 2024-06-08T20:50:31Z

@editorialbot generate preprint

editorialbot · 2024-06-08T20:51:05Z

📄 Preprint file created: Find it here in the Artifacts list 📄

editorialbot added pyOpenSci Submissions associated with pyOpenSci Python review TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jun 8, 2024

editorialbot assigned dfm Jun 8, 2024

editorialbot mentioned this issue Jun 8, 2024

[PRE REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6859

Closed

editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Jun 8, 2024

editorialbot added the accepted label Jun 8, 2024

editorialbot added the published Papers published in JOSS label Jun 8, 2024

dfm closed this as completed Jun 8, 2024

editorialbot mentioned this issue Jul 30, 2024

[PRE REVIEW]: AstroLink: A Python package for robust and interpretable astrophysical clustering #7058

Closed

editorialbot mentioned this issue Aug 30, 2024

[PRE REVIEW]: AstronomyCalc: A python toolkit for teaching Astronomical Calculations and Data Analysis methods #7160

Closed

editorialbot mentioned this issue Sep 14, 2024

[PRE REVIEW]: Halotools: A New Release Adding Intrinsic Alignments to Halo Based Methods #7224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

editorialbot commented Jun 8, 2024 •

edited

Loading

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

kyleaoman commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

kyleaoman commented Jun 8, 2024

editorialbot commented Jun 8, 2024

[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

Comments

editorialbot commented Jun 8, 2024 • edited Loading

Status

Reviewer instructions & questions

Checklists

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

kyleaoman commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024

dfm commented Jun 8, 2024

editorialbot commented Jun 8, 2024

kyleaoman commented Jun 8, 2024

editorialbot commented Jun 8, 2024

editorialbot commented Jun 8, 2024 •

edited

Loading