[PRE REVIEW]: Halotools: A New Release Adding Intrinsic Alignments to Halo Based Methods #7224
Comments
editorialbot
added
pre-review
Track: 1 (AASS)
|
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type: For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type: |
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: 🔴 Failed to discover a valid open source license |
|
|
Five most similar historical JOSS papers: limHaloPT: A Numerical Package for Accurate Modeling of Line Intensity Power Spectrum lenstronomy II: A gravitational lensing software ecosystem PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies |
|
@nvanalfen — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience! In the meantime, since halotools has previously been published can you provide more details about exactly which parts of the code should be considered for this review? It can be useful to include links to the specific git diffs, and any other context for consideration. Thanks! |
dfm
added
the
waitlisted
|
The short version is that all commits made by me ***@***.***) are part of
the review. It's hard to pin down a single piece, as Andrew was making
changes and bug fixes to the official version while I was working on this
and we had to iterate a little in the end to merge things. Here's
<nvanalfen/halotools@18e9b59>
the link to the latest commit I made on the material for this paper/work
(commit 18e9b59). And this
<nvanalfen/halotools@17422b8>
is the commit right before my first contribution (commit 17422b8). If that
comparison is sufficient (the version before I committed anything vs the
version upon my last commit), here
<https://github.com/nvanalfen/halotools/compare/17422b8..18e9b59> is the
link to that git diff.
Also, since I will be in waiting phase anyway, I might as well address some
of the editorial bot comments, but I have a couple quick questions on
those. The main one being that it found no open source license. The
halotools license is found here
<https://github.com/astropy/halotools/blob/master/licenses/LICENSE.rst>,
but it's possible it is not recognized by the automatic system. Is there a
way I can fix that or get it to pick up this fact?
My second concern is that it looks like the editorial bot couldn't find
some DOIs (It looks like 3 skipped DOIs, 2 missing, and 1 invalid "because
of 'https://doi.org/' prefix" according to the bot). I can confirm that the
2 missing DOIs do bring me to the correct paper (one is very old and is a
scan of the paper hosted on JSTOR while the other is a thesis hosted on a
DOE site), but i there something I should do to ensure the JOSS system
recognizes these? Or a way for me to adjust the citation? As for the
invalid DOI, I can simply remove the "doi.org" prefix and push the change
to my repo, but will that be sufficient or should I do something to reflect
in the system that I have fixed that issue?
Thank you for any help and please let me know if there's anything else you
need from me,
Nick
…On Fri, Sep 13, 2024 at 9:07 PM Dan Foreman-Mackey ***@***.***> wrote:
@nvanalfen <https://github.com/nvanalfen> — Thanks for your submission!
All the suitable JOSS editors are currently working at capacity so I'm
going to "waitlist" this review until an editor with the relevant expertise
is available to take it on. Thanks for your patience!
In the meantime, since halotools has previously been published can you
provide more details about exactly which parts of the code should be
considered for this review? It can be useful to include links to the
specific git diffs, and any other context for consideration. Thanks!
—
Reply to this email directly, view it on GitHub
<#7224 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJ5XA67AVYLN6AQC4TLZ4LZWOD4VAVCNFSM6AAAAABOGKWFG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQG42TONJYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nvanalfen — Thanks for the info. It's important that the reviewers know exactly which parts of the code they should be reviewing because they will need to complete the JOSS review checklist, so you'll probably need to help them throughout the process to figure out how to review the specific contributions related to this submission. You summary with commit links is a great place to start - please share that again in the main review once it starts! Regarding the license: don't worry about that check. I also found the file, and as long as the reviewers can find it too, we're not concerned about the automatic check. For the DOIs, please add the recommended DOIs if they do correspond to the correct articles and removing the |
|
@editorialbot assign @ivastar as editor |
|
Assigned! @ivastar is now the editor |
|
@nvanalfen I will be the editor for this submission. If you have any recommendations for potential reviewers, I would appreciate the help. Feel free to add names/GitHub handles here or send me an e-mail at [email protected]. |
|
@nvanalfen is the plan to eventually merge the contributions on this fork with the main |
|
@ivastar The contributions have been merged into the main repo and published on PyPI. Initially, I had forked, made my contributions, then we merged a PR into the main Also, I'm gathering names of potential reviewers and I'll send an email with those. Thanks! |
ivastar
removed
the
waitlisted
|
@editorialbot add @matroxel as reviewer |
|
@matroxel added to the reviewers list! |
|
@editorialbot add @cmlamman as reviewer |
|
@cmlamman added to the reviewers list! |
|
@editorialbot start review |
|
OK, I've started the review over in #7421. |
Submitting author: @nvanalfen (Nicholas Van Alfen)
Repository: https://github.com/nvanalfen/halotools
Branch with paper.md (empty if default branch): paper
Version: v0.9
Editor: @ivastar
Reviewers: @matroxel, @cmlamman
Managing EiC: Dan Foreman-Mackey
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @nvanalfen. Currently, there isn't a JOSS editor assigned to your paper.
@nvanalfen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: