Add deprecated parameter, for GitTools#428

openkas · Aug 19, 2015 · 0a3bc68 · 0a3bc68
1 parent 6e1db37
commit 0a3bc68
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/GitVersionExe.Tests/ArgumentParserTests.cs b/src/GitVersionExe.Tests/ArgumentParserTests.cs
@@ -316,6 +316,13 @@ public void assemblyversionformat_should_throw_warning(string args)
         exception.Message.ShouldBe("assemblyversionformat switch removed, use AssemblyVersioningScheme configuration value instead");
     }
 
+    [TestCase("-updateassemblyinfoname")]
+    public void updateassemblyinfoname_should_throw_warning(string args)
+    {
+        var exception = Should.Throw<WarningException>(() => ArgumentParser.ParseArguments(args));
+        exception.Message.ShouldBe("updateassemblyinfoname deprecated, use --updateassemblyinfo=[assemblyinfo.cs] instead");
+    }
+
     [Test]
     [TestCase("-showconfig")]
     [TestCase("--showConfig+")]

diff --git a/src/GitVersionExe/ArgumentParser.cs b/src/GitVersionExe/ArgumentParser.cs
@@ -63,7 +63,8 @@ public static OptionSet GetOptionSet(Arguments arguments)
                         v => arguments.TargetBranch = v
                     },
                     {
-                        "updateassemblyinfo:", "Will recursively search for all 'AssemblyInfo.cs' files in the git repo and update them",
+                        "updateassemblyinfo:", "Will recursively search for all 'AssemblyInfo.cs' files in the git repo and update them/n" +
+                        "Optionally specify the assembly info filename to update.",
                         v => 
                         {
                             if (v == null)
@@ -76,7 +77,11 @@ public static OptionSet GetOptionSet(Arguments arguments)
                                 arguments.UpdateAssemblyInfoFileName = v;
                             }
                         }
-                    }, // we should be able to use : as optional value here; then == null will indicate it was specified without value
+                    },
+                    {
+                        "updateassemblyinfoname", "Deprecated: use --updateassemblyinfo [assemblyinfo.cs] instead.",
+                        v => { throw new WarningException("updateassemblyinfoname deprecated, use --updateassemblyinfo=[assemblyinfo.cs] instead"); }
+                    },
                     {
                         "dynamicrepolocation=", "By default dynamic repositories will be cloned to %tmp%. Use this switch to override",
                         v => arguments.DynamicRepositoryLocation = v