Merge pull request #60 from openkraken/fix/window_set_property

fix: fix set property to window did't refer to globalThis.

bridge/bindings/jsc/KOM/window.cc

@@ -93,6 +93,26 @@ JSValueRef WindowInstance::getProperty(std::string &name, JSValueRef *exception)
   return nullptr;
 }
 
+bool WindowInstance::setProperty(std::string &name, JSValueRef value, JSValueRef *exception) {
+  auto propertyMap = getWindowPropertyMap();
+  auto prototypePropertyMap = getWindowPrototypePropertyMap();
+  JSStringHolder nameStringHolder = JSStringHolder(context, name);
+
+  // Key is prototype property, return false to handled by engine itself.
+  if (prototypePropertyMap.count(name) > 0) {
+    return false;
+  }
+
+  // Key is window's built-in property. return true to do nothing because this properties are readonly.
+  if (propertyMap.count(name) > 0) {
+    return true;
+  }
+
+  JSObjectSetProperty(_hostClass->ctx, _hostClass->context->global(), nameStringHolder.getString(), value, kJSPropertyAttributeNone, exception);
+
+  return EventTargetInstance::setProperty(name, value, exception);
+}
+
 void WindowInstance::getPropertyNames(JSPropertyNameAccumulatorRef accumulator) {
   EventTargetInstance::getPropertyNames(accumulator);
 

bridge/bindings/jsc/KOM/window.h

@@ -52,6 +52,7 @@ class WindowInstance : public EventTargetInstance {
   ~WindowInstance();
 
   JSValueRef getProperty(std::string &name, JSValueRef *exception) override;
+  bool setProperty(std::string &name, JSValueRef value, JSValueRef *exception) override;
   void getPropertyNames(JSPropertyNameAccumulatorRef accumulator) override;
 
   NativeWindow *nativeWindow;

integration_tests/specs/window/global.ts

@@ -23,6 +23,16 @@ xdescribe('windowisglobal', () => {
     expect(window.foo).toBe('foo');
   });
 
+  it('set property are sample with set into global', () => {
+    // @ts-ignore
+    window.abc = '1234';
+    // @ts-ignore
+    expect(abc).toBe('1234');
+    expect(globalThis.abc).toBe('1234');
+    // @ts-ignore
+    expect(window.abc).toBe('1234');
+  });
+
   it('onload should in window', () => {
     expect('onload' in window).toBe(true);
   });