Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor startup build scripts and README. #44

Merged
merged 5 commits into from
Mar 16, 2021
Merged

refactor: refactor startup build scripts and README. #44

merged 5 commits into from
Mar 16, 2021

Conversation

andycall
Copy link
Member

  1. 新增 npm run build:bridge:all 命令，一键构建三个平台的 bridge
  2. 添加必要的环境依赖的说明
  3. 删除一些过时的代码
  4. 支持 debug 和 release 构建

wssgcg1213
wssgcg1213 reviewed Mar 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
yuanyan
yuanyan reviewed Mar 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
yuanyan
yuanyan reviewed Mar 15, 2021
View reviewed changes
README.md Outdated
@@ -43,15 +43,16 @@ By contributing to Kraken, you agree that your contributions will be licensed un
* [Node.js](https://nodejs.org/) v12.0 or later
* [Flutter](https://flutter.dev/docs/get-started/install) version in the `kraken/pubspec.yaml`
* [CMake](https://cmake.org/)
* [Android NDK](https://developer.android.com/studio/projects/install-ndk) version `20.0.5594570` installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安卓下为什么会绑定固定版本 20.0.5594570 ？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个只是 NDK 的版本依赖

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是这个版本跑不起来？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，脚本里面写死了。不过 NDK 依赖最低也得 20，再低就跑不起来了

wssgcg1213
wssgcg1213 previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

yuanyan
yuanyan reviewed Mar 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
wssgcg1213
wssgcg1213 previously approved these changes Mar 16, 2021
View reviewed changes
@wssgcg1213 wssgcg1213 mentioned this pull request Mar 16, 2021
Closed
@andycall
Copy link
Member Author

求+1，现在 main 上的文档只能在 mac 上构建。 ios 和 android 的指引都有问题。

@andycall
Copy link
Member Author

@yuanyan

@yuanyan yuanyan merged commit fc28e26 into main Mar 16, 2021
@yuanyan yuanyan deleted the fix/bridge_doc branch March 16, 2021 07:30
@siyukok siyukok mentioned this pull request Apr 22, 2021
Closed
@AlienegraGeek AlienegraGeek mentioned this pull request Dec 27, 2021
Open
@jnxey jnxey mentioned this pull request Jan 21, 2022
Closed
@zjt123 zjt123 mentioned this pull request May 6, 2022
Closed
@zjt123 zjt123 mentioned this pull request May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yuanyan yuanyan yuanyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andycall @yuanyan @wssgcg1213