fix. gradient check wrong when has more than one right bracket #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
已添加用例 |
answershuto
previously approved these changes
Jul 20, 2021
temper357
reviewed
Jul 20, 2021
| @@ -30,6 +30,23 @@ describe('linear-gradient', () => { | |||
|
|
|||
| await snapshot(); | |||
| }); | |||
|
|
|||
| it('3', async () => { | |||
There was a problem hiding this comment.
这里用例的标题建议描述得具体些，不要用无意义的数字
temper357
reviewed
Jul 20, 2021
| @@ -30,6 +30,23 @@ describe('linear-gradient', () => { | |||
|
|
|||
| await snapshot(); | |||
| }); | |||
|
|
|||
| it('3 linear-gradient with many right brackets', async () => { | |||
temper357
approved these changes
Jul 21, 2021
answershuto
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511
原因：针对渐变校验计算规则错误，对于有多个右括号的校验无法命中，导致渐变无法渲染，示例
linear-gradient(to right, rgba(35, 35, 35, 0.8), rgba(35, 35, 35, 0.1))
修复：改为校验最后一个右括号作为完整校验