fix: free event targets properties by gc mark. #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssgcg1213
force-pushed
the
fix/event_targets_properties
branch
from
7a5046b
to
00d3d0f
Compare
yuanyan
reviewed
Dec 1, 2021
| if (JS_IsObject(m_properties)) | ||
| JS_MarkValue(rt, m_properties, mark_func); | ||
| } | ||
| void EventTargetInstance::gcMark(JSRuntime* rt, JSValue val, JS_MarkFunc* mark_func) {} |
There was a problem hiding this comment.
这个函数是空的，需要注释说明下，目前c++代码注释是比较少的
answershuto
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在一些特殊的条件下（例如节点被卸载）等，gc_mark 无法正确被 GC 掉用，从而导致对象内部和对象本身没有绑定的属性无法释放。
先采用 Object.defineProperty 这样的方式来绑定属性，可以确保属性 100% 可以被 GC 定位并释放