enhancement: ambiguous function name of isSidecarSetNotUpdate #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
Welcome @Colvin-Y! It looks like this is your first PR to openkruise/kruise 🎉 |
Signed-off-by: Colvin-Y <[email protected]>
Colvin-Y
force-pushed
the
enhancement/isSidecarSetNotUpdate
branch
from
77a59da
to
66875b6
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1343 +/- ##
=======================================
Coverage 48.60% 48.60%
=======================================
Files 152 152
Lines 21333 21333
=======================================
Hits 10369 10369
Misses 9828 9828
Partials 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Aug 29, 2023
…uise#1343) Signed-off-by: Colvin-Y <[email protected]>
lilongfeng0902
pushed a commit
to lilongfeng0902/kruise
that referenced
this pull request
Sep 12, 2023
…uise#1343) Signed-off-by: Colvin-Y <[email protected]>
BH4AWS
pushed a commit
to BH4AWS/kruise
that referenced
this pull request
Jan 23, 2024
Normandy 相关问题，所有发布的 Pod 都会在 Pod 创建瞬间被算成 publish-success-replicas Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/13622663 * optimize webhook patchResponse function (openkruise#1334) Signed-off-by: liheng.zms <[email protected]> * enhancement: ambiguous function name of isSidecarSetNotUpdate (openkruise#1343) Signed-off-by: Colvin-Y <[email protected]> * veophi apply to become an owner of kruise (openkruise#1350) Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> * Fix tools/kind are lost (openkruise#1355) Signed-off-by: acejilam <[email protected]> * [enhancement] fix comment error for function isJobFailed of broadcastjob (openkruise#1348) Signed-off-by: Colvin-Y <[email protected]> * cloneset watch changes to pods' ownerRef (openkruise#1358) Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> * Update internal develop based on v0.6.0 * Add prepare.sh for ut * Add update timestamp in pod-spec-hash and support postpone * Avoid inject additional envs during pods in-place updated by CloneSet * Fix cloneset pod handler for opensource * Improve safeyout injection for CloneSet * Fix ASI CloneSet regex * Support batch order for CloneSet updating * Update controller-runtime v0.5.0-beta.10.0 * enable pprof * imagepuller: support containerd under standard path * Update go modules vendor * add rate-limiter-max-delay * fix ExtraStatusCalculation definition * optimize crd create or replace in start shell * cloneset add publish success replicas * cloneset pod add publish id * Fix log rotate * Enable the new SidecarSet and kruise-daemon * Add account-manager for daemon * Add aaa- as prefix of MutatingWebhookConfig name * add batch id Signed-off-by: 周刷 <[email protected]> * New generation for nodeimage and imagepulljob * enable acj,bcj,ud * add feature-gates into start script * Use inplace update options defaults * cloneset add app state count * Fetch CRD yamls to v0.8.0 * Change default feature-gates for ASI * Update manifests to v0.9.0-alpha.0 * fix no container name bug * Remove useless image-puller * Update image pre-download default parallelism to 3 * add dockerfile for aarch64 * fix timezone for docker tag timestamp * [asi]sidecarset hot upgrade feature * Update yamls to v0.9.0 * Add simple GetPodSpreadConstraint for asi cloneset core * sidecarset proxy asi * check if it is containerd when there is pouchcri.sock but no pouch.sock Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6089994 * check if it is containerd when there is pouchcri.sock but no pouch.sock * remove minute in docker image tag * fetch upstream pre-v0.10.0 * support ASI PodConstraint for CloneSet scaledown spread Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6217897 * support ASI PodConstraint for CloneSet scaledown spread * Update all client api for k8s 1.18 * fix sidecar container namge changed panic Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6286449 * fix sidecar container namge changed panic * 支持向label中注入公网外联开关信息 当上层业务通过annotation打开注入开关时, 控制器会将应用分组的公网外联开关信息注入到pod label中供下游消费 * allow proxy cloneset to change update type * Bump k8s 1.20 and apiextensions.k8s.io/admissionregistration.k8s.io to v1 * CloneSet pooling adopts pvcs with pod * Make InPlaceUpdateEnvFromMetadata defaults enabled and disable resync-period * asi pub control Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6685801 * asi pub control * Optimize cloneset asi update sort Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6865232 * Optimize cloneset asi update sort * Update CRDs based on upstream * 增强publish-success-replicas逻辑 Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7118360 * enhance publish success replicas logic: pod.status.condidtion[*].type no schedule also true * Only inject ali_safety_out env for fat containers Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7216531 * Only inject ali_safety_out env for fat containers * support ephemeral job in asi Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7220417 * support ephemeral job in asi * support ephemeral job in asi * support ephemeral job in asi add asi e2e test * Improve for the pre-v1.1 upstream, e.g., disable deepcopy, 1.22 * Support upgrade-merge-labels * Disable feature-gate DaemonWatchingPod and InPlaceUpdateEnvFromMetadata * Update internal CRDs * Fix cloneset asi core to adapt inplace-update * Add expectedUpdatedReplicas into CloneSet status * pub control asi intreface Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/8609991 * pub control asi intreface * pub control asi intreface * pub control asi intreface * fix pod schedule bug Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/8646154 * fix pod schedule bug * Update internal CRDs for markPodNotReady in lifecycle * Add PersistentPodState into internal CRDs and webhook configuration * add lifecycle readiness asi mode Lifecycle MarkPodNotReady 内部实现，当 KruisePodReady 不存在时，会给 Pod Patch 一个； 场景是 SAE 流量无损发布。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/8797375 * add lifecycle readiness asi mode Signed-off-by: mingzhou.swx <[email protected]> * Fix controllerfinder.Finder for pub_control_asi.go * Update DaemonSet CRD additionalPrinterColumns * Rebase utilclient cache and pod mutating webhook optimization * Ignore and remove KruisePodReady readinessGate on Pod with hippo version v2.5 * cloneset support scale versioned pods with percent-partition 1. 保留 Normandy 目前的发布方式 2. CloneSet 支持 Normandy 比例发布，若用户配置百分比 Partition，则按照 Partition 来扩缩容新旧版本的 Pod。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9417926 * cloneset support scale versioned pods with percent-partition Signed-off-by: mingzhou.swx <[email protected]> * Add cloneset-scaling-exclude-preparing-delete args into start-kruise.sh * fix sidecarset asi apps function Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9504721 * fix sidecarset asi apps function * Update SidecarSet CRD YAML with injection revision and patchPodMetadata * Support chorus dind build Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9620240 * Support chorus dind build * Add BUILDPLATFORM and TARGETARCH in Dockerfile Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9624012 * Add BUILDPLATFORM and TARGETARCH in Dockerfile * fix asi sidecar UpdatePodAnnotationsInUpgrade function * container exit priority controller Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9752825 * container exit priority controller * Add rollout label when CloneSet creating update-revision pod 解决 Normandy 发布，置换 Pod 时， 需要 Patch 当前批次标的问题。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9774736 * add rollout label when update-revision pod creating for cloneset Signed-off-by: mingzhou.swx <[email protected]> * Migrate build and base images from hangzhou to shanghai * WorkloadSpread controller workers 数量默认设置为20 目前 ws 在弹性场景已经当规模使用，性能问题需要继续打磨 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9909078 * set default workloadspread workers = 20 Signed-off-by: mingzhou.swx <[email protected]> * CloneSet watch lifecycle finalizer changes 用户配置了 lifecycle finalizer hook，但是 cloneset 并没有 watch finalizer 变化，导致 Pod 下线、升级有可能被卡住 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/10106025 * cloneset watch lifecycle finalizer changes Signed-off-by: mingzhou.swx <[email protected]> * Update AdvancedCronJob CRD with TimeZone * Support unified inplace udpate API for Pods on VK Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9518532 * Support unified inplace udpate API for Pods on VK * Support unified inplace udpate API for Pods on VK * upstream kruise 1.3.0 CRD,Webhook,Feature-gates * add asi mode for pod readiness control Signed-off-by: mingzhou.swx <[email protected]> * 临时容器接口同时兼容1.20 1.22 API 临时容器接口同时兼容1.20 1.22 API Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/11254413 * remove empheral container 接口兼容1.20 1.22 Signed-off-by: mingzhou.swx <[email protected]> * sync kruise crds to develop * optimize cloneset event handler codes Signed-off-by: mingzhou.swx <[email protected]> * Fix sidecarset asi e2e function * sync upstream v1.4.0 crds * fix cloneset event handler ut function * 支持cloneset inplaceifpossible->inplaceonly 转换 融合项目关于接管国际化cloneset的workload从ifpossilble模式到only模式的问题和解决方案：https://aone.alibaba-inc.com/v2/project/1003533/req/48536815 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12081365 * 支持cloneset inplaceifpossible->inplaceonly 转换 Signed-off-by: mingzhou.swx <[email protected]> * CloneSet rollout-id 打标逻辑外移至单独控制器 支持集团融合项目打标需求 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12253692 * add label patcher controller for normandy Signed-off-by: mingzhou.swx <[email protected]> * add label patcher controller for normandy Signed-off-by: mingzhou.swx <[email protected]> * fix ephemeral job e2e Signed-off-by: mingzhou.swx <[email protected]> * support aone acr repository change Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12464256 * support for new aone registry and user account Signed-off-by: 守辰 <[email protected]> * support aone acr repository change * support for new aone registry and user account Signed-off-by: 守辰 <[email protected]> * optimize the update logic to cloneset extra status Signed-off-by: mingzhou.swx <[email protected]> * make updateReadyReplicas as updatedAvailableReplicas temporily Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12503661 * make updateReadyReplicas as updatedAvailableReplicas temporily Signed-off-by: mingzhou.swx <[email protected]> * restrict the access permissions of kruise-daemon to secrets Signed-off-by: mingzhou.swx <[email protected]> * fix cloneset update extra status Signed-off-by: mingzhou.swx <[email protected]> * container exit priority support csk Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/13341278 * container exit priority support csk * optimize kruise start args 1. 支持 参数配置 kruise args 2. default：leader-election-lease-duration=20s，leader-election-renew-deadline=15s，leader-election-resource-lock=leases 3. default：controller-cache-sync-timeout=10m Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/13243487 * optimize kruise start args * add imagelistpulljob api Signed-off-by: mingzhou.swx <[email protected]> * publish-success pod's scheduled condition should not be nil Signed-off-by: mingzhou.swx <[email protected]> * fix normandy publish-success-replicas unscheduled pod logic Signed-off-by: mingzhou.swx <[email protected]> * fix normandy publish-success-replicas unscheduled pod logic Signed-off-by: mingzhou.swx <[email protected]> * Update internal develop based on v0.6.0 * Add prepare.sh for ut * Add update timestamp in pod-spec-hash and support postpone * Avoid inject additional envs during pods in-place updated by CloneSet * Fix cloneset pod handler for opensource * Improve safeyout injection for CloneSet * Fix ASI CloneSet regex * Support batch order for CloneSet updating * Update controller-runtime v0.5.0-beta.10.0 * enable pprof * imagepuller: support containerd under standard path * Update go modules vendor * add rate-limiter-max-delay * fix ExtraStatusCalculation definition * optimize crd create or replace in start shell * cloneset add publish success replicas * cloneset pod add publish id * Fix log rotate * Enable the new SidecarSet and kruise-daemon * Add account-manager for daemon * Add aaa- as prefix of MutatingWebhookConfig name * add batch id Signed-off-by: 周刷 <[email protected]> * New generation for nodeimage and imagepulljob * enable acj,bcj,ud * add feature-gates into start script * Use inplace update options defaults * cloneset add app state count * Fetch CRD yamls to v0.8.0 * Change default feature-gates for ASI * Update manifests to v0.9.0-alpha.0 * fix no container name bug * Remove useless image-puller * Update image pre-download default parallelism to 3 * add dockerfile for aarch64 * fix timezone for docker tag timestamp * [asi]sidecarset hot upgrade feature * Update yamls to v0.9.0 * Add simple GetPodSpreadConstraint for asi cloneset core * sidecarset proxy asi * check if it is containerd when there is pouchcri.sock but no pouch.sock Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6089994 * check if it is containerd when there is pouchcri.sock but no pouch.sock * remove minute in docker image tag * fetch upstream pre-v0.10.0 * support ASI PodConstraint for CloneSet scaledown spread Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6217897 * support ASI PodConstraint for CloneSet scaledown spread * Update all client api for k8s 1.18 * fix sidecar container namge changed panic Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6286449 * fix sidecar container namge changed panic * 支持向label中注入公网外联开关信息 当上层业务通过annotation打开注入开关时, 控制器会将应用分组的公网外联开关信息注入到pod label中供下游消费 * allow proxy cloneset to change update type * Bump k8s 1.20 and apiextensions.k8s.io/admissionregistration.k8s.io to v1 * CloneSet pooling adopts pvcs with pod * Make InPlaceUpdateEnvFromMetadata defaults enabled and disable resync-period * asi pub control Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6685801 * asi pub control * Optimize cloneset asi update sort Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/6865232 * Optimize cloneset asi update sort * Update CRDs based on upstream * 增强publish-success-replicas逻辑 Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7118360 * enhance publish success replicas logic: pod.status.condidtion[*].type no schedule also true * Only inject ali_safety_out env for fat containers Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7216531 * Only inject ali_safety_out env for fat containers * support ephemeral job in asi Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/7220417 * support ephemeral job in asi * support ephemeral job in asi * support ephemeral job in asi add asi e2e test * Improve for the pre-v1.1 upstream, e.g., disable deepcopy, 1.22 * Support upgrade-merge-labels * Disable feature-gate DaemonWatchingPod and InPlaceUpdateEnvFromMetadata * Update internal CRDs * Fix cloneset asi core to adapt inplace-update * Add expectedUpdatedReplicas into CloneSet status * pub control asi intreface Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/8609991 * pub control asi intreface * pub control asi intreface * pub control asi intreface * fix pod schedule bug Link: https://code.aone.alibaba-inc.com/ak8s-ee/kruise/codereview/8646154 * fix pod schedule bug * Update internal CRDs for markPodNotReady in lifecycle * Add PersistentPodState into internal CRDs and webhook configuration * add lifecycle readiness asi mode Lifecycle MarkPodNotReady 内部实现，当 KruisePodReady 不存在时，会给 Pod Patch 一个； 场景是 SAE 流量无损发布。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/8797375 * add lifecycle readiness asi mode Signed-off-by: mingzhou.swx <[email protected]> * Fix controllerfinder.Finder for pub_control_asi.go * Update DaemonSet CRD additionalPrinterColumns * Rebase utilclient cache and pod mutating webhook optimization * Ignore and remove KruisePodReady readinessGate on Pod with hippo version v2.5 * cloneset support scale versioned pods with percent-partition 1. 保留 Normandy 目前的发布方式 2. CloneSet 支持 Normandy 比例发布，若用户配置百分比 Partition，则按照 Partition 来扩缩容新旧版本的 Pod。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9417926 * cloneset support scale versioned pods with percent-partition Signed-off-by: mingzhou.swx <[email protected]> * Add cloneset-scaling-exclude-preparing-delete args into start-kruise.sh * fix sidecarset asi apps function Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9504721 * fix sidecarset asi apps function * Update SidecarSet CRD YAML with injection revision and patchPodMetadata * Support chorus dind build Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9620240 * Support chorus dind build * Add BUILDPLATFORM and TARGETARCH in Dockerfile Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9624012 * Add BUILDPLATFORM and TARGETARCH in Dockerfile * fix asi sidecar UpdatePodAnnotationsInUpgrade function * container exit priority controller Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9752825 * container exit priority controller * Add rollout label when CloneSet creating update-revision pod 解决 Normandy 发布，置换 Pod 时， 需要 Patch 当前批次标的问题。 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9774736 * add rollout label when update-revision pod creating for cloneset Signed-off-by: mingzhou.swx <[email protected]> * Migrate build and base images from hangzhou to shanghai * WorkloadSpread controller workers 数量默认设置为20 目前 ws 在弹性场景已经当规模使用，性能问题需要继续打磨 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9909078 * set default workloadspread workers = 20 Signed-off-by: mingzhou.swx <[email protected]> * CloneSet watch lifecycle finalizer changes 用户配置了 lifecycle finalizer hook，但是 cloneset 并没有 watch finalizer 变化，导致 Pod 下线、升级有可能被卡住 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/10106025 * cloneset watch lifecycle finalizer changes Signed-off-by: mingzhou.swx <[email protected]> * Update AdvancedCronJob CRD with TimeZone * Support unified inplace udpate API for Pods on VK Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/9518532 * Support unified inplace udpate API for Pods on VK * Support unified inplace udpate API for Pods on VK * upstream kruise 1.3.0 CRD,Webhook,Feature-gates * add asi mode for pod readiness control Signed-off-by: mingzhou.swx <[email protected]> * 临时容器接口同时兼容1.20 1.22 API 临时容器接口同时兼容1.20 1.22 API Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/11254413 * remove empheral container 接口兼容1.20 1.22 Signed-off-by: mingzhou.swx <[email protected]> * sync kruise crds to develop * optimize cloneset event handler codes Signed-off-by: mingzhou.swx <[email protected]> * Fix sidecarset asi e2e function * sync upstream v1.4.0 crds * fix cloneset event handler ut function * 支持cloneset inplaceifpossible->inplaceonly 转换 融合项目关于接管国际化cloneset的workload从ifpossilble模式到only模式的问题和解决方案：https://aone.alibaba-inc.com/v2/project/1003533/req/48536815 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12081365 * 支持cloneset inplaceifpossible->inplaceonly 转换 Signed-off-by: mingzhou.swx <[email protected]> * CloneSet rollout-id 打标逻辑外移至单独控制器 支持集团融合项目打标需求 Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12253692 * add label patcher controller for normandy Signed-off-by: mingzhou.swx <[email protected]> * add label patcher controller for normandy Signed-off-by: mingzhou.swx <[email protected]> * fix ephemeral job e2e Signed-off-by: mingzhou.swx <[email protected]> * support aone acr repository change Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12464256 * support for new aone registry and user account Signed-off-by: 守辰 <[email protected]> * support aone acr repository change * support for new aone registry and user account Signed-off-by: 守辰 <[email protected]> * optimize the update logic to cloneset extra status Signed-off-by: mingzhou.swx <[email protected]> * make updateReadyReplicas as updatedAvailableReplicas temporily Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/12503661 * make updateReadyReplicas as updatedAvailableReplicas temporily Signed-off-by: mingzhou.swx <[email protected]> * restrict the access permissions of kruise-daemon to secrets Signed-off-by: mingzhou.swx <[email protected]> * fix cloneset update extra status Signed-off-by: mingzhou.swx <[email protected]> * container exit priority support csk Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/13341278 * container exit priority support csk * optimize kruise start args 1. 支持 参数配置 kruise args 2. default：leader-election-lease-duration=20s，leader-election-renew-deadline=15s，leader-election-resource-lock=leases 3. default：controller-cache-sync-timeout=10m Link: https://code.alibaba-inc.com/ak8s-ee/kruise/codereview/13243487 * optimize kruise start args * add imagelistpulljob api Signed-off-by: mingzhou.swx <[email protected]> * fix normandy publish-success-replicas unscheduled pod logic Signed-off-by: mingzhou.swx <[email protected]> * fix normandy publish-success-replicas unscheduled pod logic Signed-off-by: mingzhou.swx <[email protected]>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix #1342
This modification only fixes the ambiguity between the implementation and the name of the function isSidecarSetNotUpdate, without altering the original logic.
Ⅱ. Does this pull request fix one issue?
fix #1342
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews