[FIX] BroadcastJob activeDeadlineSeconds did not take effect

[ls-2018]

• [BUG] BroadcastJob activeDeadlineSeconds did not take effect #1409

A description of the specific problem is in issue

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 47.88%. Comparing base (dad39bc) to head (3183a64).

Files	Patch %	Lines
...controller/broadcastjob/broadcastjob_controller.go	41.66%	5 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   47.90%   47.88%   -0.02%     
==========================================
  Files         161      161              
  Lines       23425    23435      +10     
==========================================
+ Hits        11222    11223       +1     
- Misses      10989    10995       +6     
- Partials     1214     1217       +3     

Flag	Coverage Δ
unittests	47.88% <41.66%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zmberg]

Why must this official function be redefine, and official functions are best left unmodified.

[zmberg]

@ls-2018 My local validation is working and this code place jobFailed is true and then it will delete all Pods.

[kruise-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ls-2018]

I simplified the code a little bit.

Reconcile all of the Reconcile function can be handled because AdvancedCronJob, BroadcastJob and Job events occur. However, in the case I submitted, I watched three kinds of resources respectively and found that no incident happened. Of course, this probability may be low, but it is not impossible

[zmberg]

What I'm more interested in understanding is how this patch related to the issue? Bug?

[ls-2018]

I think it was a bug.
Pulling the large image exceeded the expected death time, but the pod could not be killed because no event was watched.No event changes at this time

[zmberg]

@ls-2018 You are right, and i think you can refer the implement, https://github.com/openkruise/rollouts/blob/master/pkg/controller/rollout/rollout_controller.go#L167

[ls-2018]

I think I have found the root cause. It is not that the ActiveDeadlineSeconds have not been reconciled after expiration, but that there is no judgment on whether the pod should be removed or not.
@zmberg

[ls-2018]

@zmberg Can you look at this request again please? Thanks.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.