Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support specified-delete in asts #1734

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Sep 9, 2024

Ⅰ. Describe what this PR does

support specified-delete in asts

Ⅱ. Does this pull request fix one issue?

fixes #951

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (0d0031a) to head (a9206e7).
Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/statefulset/stateful_set_control.go 58.33% 8 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   47.91%   49.17%   +1.25%     
==========================================
  Files         162      191      +29     
  Lines       23491    19595    -3896     
==========================================
- Hits        11256     9636    -1620     
+ Misses      11014     8701    -2313     
- Partials     1221     1258      +37     
Flag Coverage Δ
unittests 49.17% <58.33%> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 changed the title support specified-delete in asts [WIP]support specified-delete in asts Sep 10, 2024
@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch from 99242e1 to a6e1d2a Compare September 10, 2024 13:13
@ABNER-1 ABNER-1 changed the title [WIP]support specified-delete in asts support specified-delete in asts Sep 10, 2024
@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch from a6e1d2a to cf50f43 Compare September 11, 2024 01:29
@ABNER-1 ABNER-1 requested a review from veophi September 11, 2024 07:08
@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch 4 times, most recently from 649e76e to 14d8fd8 Compare September 12, 2024 04:58
@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch 2 times, most recently from 16b2ecf to c5f0089 Compare September 12, 2024 06:24
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch from c5f0089 to eb2e8d0 Compare September 13, 2024 03:51
@ABNER-1 ABNER-1 force-pushed the support-specified-delete-in-asts branch from eb2e8d0 to a9206e7 Compare September 13, 2024 05:46
@furykerry
Copy link
Member

/lgtm

1 similar comment
@zmberg
Copy link
Member

zmberg commented Sep 18, 2024

/lgtm

@zmberg zmberg merged commit 6d57029 into openkruise:master Sep 18, 2024
43 of 44 checks passed
ABNER-1 added a commit that referenced this pull request Sep 18, 2024
ABNER-1 added a commit that referenced this pull request Sep 19, 2024
ABNER-1 added a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add pod specified-delete for advanced statefulset
4 participants