Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: follower should try clean pending closure to avoid memory leak #309

Merged
merged 5 commits into from
Aug 11, 2023
Merged

fix: follower should try clean pending closure to avoid memory leak #309

merged 5 commits into from
Aug 11, 2023

Conversation

absolute8511
Copy link
Contributor

@absolute8511 absolute8511 commented Aug 8, 2023 •
edited
Loading

Change-Id: I24b4cc67d66d7fba3ae4c46480da1af1c769479d

Fix some possible memory leak:

  1. timeout response check should remove map index
  2. follower should check and clean old pending closure since it may changed from leader which will has old data

liwen.2022 added 2 commits August 8, 2023 20:17
fix: follower should try clean pending closure to avoid memory leak
c63a498 
Change-Id: I24b4cc67d66d7fba3ae4c46480da1af1c769479d
fix: check timeout pending closureMap in follower role
2c8e85f 
Change-Id: I7e392579087171574e2a88d6d1cae21f0773510a
TheR1sing3un
TheR1sing3un approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@TheR1sing3un
Copy link
Contributor

@RongtongJin Hi, PTAL!

@TheR1sing3un
Copy link
Contributor

@absolute8511 Plz fix the CI. If the reason for the failure has nothing to do with your change, just ignore it, I will fix these flaky test later~

liwen.2022 added 2 commits August 9, 2023 13:32
fix: check timeout should check all since it may removed old index
e0969d3 
Change-Id: Ia5bd6255188294bcf73130bee1669b7a646ab0ad
optimize: check timeout more efficient
ea26125 
Change-Id: I103c0aad5bcc313cce02e091f7cd11bf4dd0eb32
optimize the timeout future check
37c7bfe 
Change-Id: Id339e9e0d3e697c5bfcd3330c43ea751ed024911
@RongtongJin RongtongJin merged commit 0156c72 into openmessaging:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

@TheR1sing3un TheR1sing3un TheR1sing3un approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@absolute8511 @TheR1sing3un @RongtongJin