TRUNK-5480: Make ModuleUtil support more version specification format #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you always include a link to the ticket as recommend at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
@dkayiwa Noted! I will add the links and other required informations as I'm still working on the ticket. |
ibacher
reviewed
Apr 8, 2024
| if (lowerBound.indexOf("*") > 0) { | ||
| lowerBound = lowerBound.replaceAll("\\*", "0"); | ||
| }else if (lowerBound.indexOf("+") > 0) { |
There was a problem hiding this comment.
Suggested change
| }else if (lowerBound.indexOf("+") > 0) { | |
| } else if (lowerBound.indexOf("+") > 0) { |
| @@ -773,4 +773,18 @@ protected File getEmptyJarDestinationFolder() throws IOException { | |||
| } | |||
| return destinationFolder; | |||
| } | |||
|
|
|||
| @Test | |||
| public void matchRequiredVersions_shouldAllowRangedUsingPlusSignVersion() { | |||
There was a problem hiding this comment.
Couple of thoughts here:
- We want to test the simple cases, i.e. 1.4+, etc..
- Did you see my comment on the ticket here, because I'm not sure that
2.2.5+ - 3.19.2+is clear. - I think the easiest way to get the requested behavior without a lot of changes is to only support the forms:
1.4+,1+, and1.4.2+, i.e., don't support the+without the separator (-). (This would make it similar to, e.g., Node and Rust's.Xsuffix). - The comments on the
+format should mention that it's only available on platform 2.7+. - It would be good to have some checks on the boundaries, i.e.,
1.4+should be strictly equivalent to1.4.0 - 1.4.*,1.4.2+should be equivalent to1.4.2 - 1.4.*, etc.
There was a problem hiding this comment.
Regarding the last recommendation, I hope it doesn't require the complexity that we are avoiding to check all this scenarios.
Therefore, I agree with the recommendations and explanations!
I will apply the changes and reach out to you for any concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5480
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master