O3-2996: Add billing module to openmrs distro pom file and spa config #842
Conversation
… in which deps on coreapps et al have been removed
ODORA0
changed the title
ODORA0
force-pushed
the
alaboso-feat/billing-mvp
branch
from
0bf624a
to
9886497
Compare
ODORA0
force-pushed
the
alaboso-feat/billing-mvp
branch
from
9886497
to
80301dc
Compare
|
Woohoo!! It will be great to have this included in the O3 RefApp / EMR distro. |
distro/pom.xml
Outdated
| @@ -49,6 +49,11 @@ | |||
| <ordertemplates.version>1.0.2</ordertemplates.version> | |||
| <patientflags.version>3.0.7</patientflags.version> | |||
| <o3forms.version>2.3.0-SNAPSHOT</o3forms.version> | |||
| <patientflags.version>3.0.5</patientflags.version> | |||
There was a problem hiding this comment.
Did you intentionally change the patient flags and o2forms modules?
There was a problem hiding this comment.
Removed, slipped somehow during conflict resolution.
distro/pom.xml
Outdated
| @@ -49,6 +49,9 @@ | |||
| <ordertemplates.version>1.0.2</ordertemplates.version> | |||
| <patientflags.version>3.0.7</patientflags.version> | |||
| <o3forms.version>2.3.0-SNAPSHOT</o3forms.version> | |||
| <!-- Stock Management and Billing --> | |||
| <stockmanagement.version>2.0.1-SNAPSHOT</stockmanagement.version> | |||
There was a problem hiding this comment.
For the above, did you intend to use 2.0.2-SNAPSHOT?
distro/pom.xml
Outdated
| @@ -49,6 +49,9 @@ | |||
| <ordertemplates.version>1.0.2</ordertemplates.version> | |||
| <patientflags.version>3.0.7</patientflags.version> | |||
| <o3forms.version>2.3.0-SNAPSHOT</o3forms.version> | |||
| <!-- Stock Management and Billing --> | |||
| <stockmanagement.version>2.0.1-SNAPSHOT</stockmanagement.version> | |||
| <billing.version>1.1.0</billing.version> | |||
There was a problem hiding this comment.
Has version 1.1.0 of the billing module been released?
There was a problem hiding this comment.
Yes, this was released. We had to do this also when we were adding domains to iniz that depends on the released version of the module
There was a problem hiding this comment.
I failed to find such a release from this repository: https://github.com/openmrs/openmrs-module-billing
Or are you using another repository?
There was a problem hiding this comment.
I think there was a manual release on BambooCI, link
Could there be a reason why you set this to false? https://github.com/openmrs/openmrs-module-billing/blob/main/pom.xml#L367
For I notice that no tag was created on github https://github.com/openmrs/openmrs-module-billing/tags
And the billing module is still having 1.1.0-SNAPSHOT https://github.com/openmrs/openmrs-module-billing/blob/main/pom.xml#L8
There was a problem hiding this comment.
We didn't set that to false, it must have been a default value and we didn't catch it. We will fix it.
There was a problem hiding this comment.
The module versions changed and the push configuration updated
There was a problem hiding this comment.
Could there be a reason why you are not using the latest snapshot version 1.2.0-SNAPSHOT of this module to take advantage of the latest changes? Just like you have done for the stockmanagement module.
ODORA0
force-pushed
the
alaboso-feat/billing-mvp
branch
from
de0192b
to
9ef5aa3
Compare
This PR is to introduce the Billing and StockManagement modules to the reference application. Billing requires Stock Management as a dependency.