Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Remove unused SystemJS-related code #677

Merged
merged 2 commits into from
May 22, 2023

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR is required for openmrs/openmrs-esm-patient-chart#1168 to work. It removes the legacy module loading approach, paving the way for a singular module loading strategy predicated on webpack module federation.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Size Change: -232 B (0%)

Total Size: 2.12 MB

Filename Size Change
packages/shell/esm-app-shell/dist/openmrs.862f6daef4a013f6.js 0 B -228 kB (removed) 🏆
packages/shell/esm-app-shell/dist/openmrs.1bfd6c38c44df7af.js 228 kB +228 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/68.js 4.23 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/889.js 111 kB
packages/apps/esm-devtools-app/dist/988.js 366 B
packages/apps/esm-devtools-app/dist/main.js 2.87 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.04 kB
packages/apps/esm-implementer-tools-app/dist/102.js 2.76 kB
packages/apps/esm-implementer-tools-app/dist/139.js 11.7 kB
packages/apps/esm-implementer-tools-app/dist/242.js 6.72 kB
packages/apps/esm-implementer-tools-app/dist/246.js 447 B
packages/apps/esm-implementer-tools-app/dist/305.js 5.07 kB
packages/apps/esm-implementer-tools-app/dist/319.js 458 B
packages/apps/esm-implementer-tools-app/dist/369.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/426.js 1.66 kB
packages/apps/esm-implementer-tools-app/dist/466.js 5.82 kB
packages/apps/esm-implementer-tools-app/dist/574.js 425 B
packages/apps/esm-implementer-tools-app/dist/587.js 4.03 kB
packages/apps/esm-implementer-tools-app/dist/600.js 61.8 kB
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB
packages/apps/esm-implementer-tools-app/dist/696.js 29.3 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/807.js 1.46 kB
packages/apps/esm-implementer-tools-app/dist/889.js 111 kB
packages/apps/esm-implementer-tools-app/dist/895.js 2.29 kB
packages/apps/esm-implementer-tools-app/dist/main.js 3.93 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.27 kB
packages/apps/esm-login-app/dist/236.js 272 B
packages/apps/esm-login-app/dist/240.js 364 B
packages/apps/esm-login-app/dist/261.js 6.25 kB
packages/apps/esm-login-app/dist/263.js 6.66 kB
packages/apps/esm-login-app/dist/272.js 264 B
packages/apps/esm-login-app/dist/319.js 360 B
packages/apps/esm-login-app/dist/336.js 234 B
packages/apps/esm-login-app/dist/337.js 1.62 kB
packages/apps/esm-login-app/dist/390.js 603 B
packages/apps/esm-login-app/dist/438.js 6 kB
packages/apps/esm-login-app/dist/539.js 298 B
packages/apps/esm-login-app/dist/574.js 428 B
packages/apps/esm-login-app/dist/610.js 5.8 kB
packages/apps/esm-login-app/dist/611.js 726 B
packages/apps/esm-login-app/dist/63.js 16.5 kB
packages/apps/esm-login-app/dist/642.js 10.7 kB
packages/apps/esm-login-app/dist/644.js 305 B
packages/apps/esm-login-app/dist/673.js 284 B
packages/apps/esm-login-app/dist/735.js 2.63 kB
packages/apps/esm-login-app/dist/737.js 24.9 kB
packages/apps/esm-login-app/dist/757.js 603 B
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/829.js 10 kB
packages/apps/esm-login-app/dist/889.js 111 kB
packages/apps/esm-login-app/dist/main.js 3.3 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.18 kB
packages/apps/esm-offline-tools-app/dist/206.js 7.28 kB
packages/apps/esm-offline-tools-app/dist/263.js 6.67 kB
packages/apps/esm-offline-tools-app/dist/264.js 9.5 kB
packages/apps/esm-offline-tools-app/dist/281.js 12.3 kB
packages/apps/esm-offline-tools-app/dist/290.js 438 B
packages/apps/esm-offline-tools-app/dist/316.js 2.06 kB
packages/apps/esm-offline-tools-app/dist/391.js 305 B
packages/apps/esm-offline-tools-app/dist/412.js 1.58 kB
packages/apps/esm-offline-tools-app/dist/47.js 6.31 kB
packages/apps/esm-offline-tools-app/dist/501.js 23.2 kB
packages/apps/esm-offline-tools-app/dist/526.js 15.4 kB
packages/apps/esm-offline-tools-app/dist/538.js 6.75 kB
packages/apps/esm-offline-tools-app/dist/541.js 384 B
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/594.js 11.2 kB
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/697.js 5.47 kB
packages/apps/esm-offline-tools-app/dist/733.js 290 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/752.js 2.83 kB
packages/apps/esm-offline-tools-app/dist/757.js 1.15 kB
packages/apps/esm-offline-tools-app/dist/78.js 6.13 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/82.js 51.7 kB
packages/apps/esm-offline-tools-app/dist/889.js 111 kB
packages/apps/esm-offline-tools-app/dist/937.js 6.46 kB
packages/apps/esm-offline-tools-app/dist/967.js 492 B
packages/apps/esm-offline-tools-app/dist/main.js 58 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.26 kB
packages/apps/esm-primary-navigation-app/dist/113.js 11.6 kB
packages/apps/esm-primary-navigation-app/dist/216.js 549 B
packages/apps/esm-primary-navigation-app/dist/241.js 13.8 kB
packages/apps/esm-primary-navigation-app/dist/242.js 6.72 kB
packages/apps/esm-primary-navigation-app/dist/363.js 3 kB
packages/apps/esm-primary-navigation-app/dist/406.js 9.38 kB
packages/apps/esm-primary-navigation-app/dist/414.js 467 B
packages/apps/esm-primary-navigation-app/dist/574.js 183 B
packages/apps/esm-primary-navigation-app/dist/631.js 1.07 kB
packages/apps/esm-primary-navigation-app/dist/710.js 6.28 kB
packages/apps/esm-primary-navigation-app/dist/716.js 6.08 kB
packages/apps/esm-primary-navigation-app/dist/735.js 2.64 kB
packages/apps/esm-primary-navigation-app/dist/743.js 7.05 kB
packages/apps/esm-primary-navigation-app/dist/757.js 209 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/889.js 111 kB
packages/apps/esm-primary-navigation-app/dist/main.js 9.4 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.28 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 10.1 kB
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 3.24 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 1.87 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 1.49 kB
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.46 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 238 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 1.59 kB
packages/framework/esm-offline/dist/openmrs-esm-offline.js 35 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 18 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 1.53 kB
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.8 kB
packages/shell/esm-app-shell/dist/19321bffcf2a2978.js 1.58 kB
packages/shell/esm-app-shell/dist/service-worker.js 57.4 kB
packages/tooling/openmrs/dist/cli.js 2.92 kB
packages/tooling/openmrs/dist/commands/assemble.js 2.48 kB
packages/tooling/openmrs/dist/commands/build.js 1.41 kB
packages/tooling/openmrs/dist/commands/debug.js 539 B
packages/tooling/openmrs/dist/commands/develop.js 1.66 kB
packages/tooling/openmrs/dist/commands/index.js 360 B
packages/tooling/openmrs/dist/commands/start.js 848 B
packages/tooling/openmrs/dist/index.js 445 B
packages/tooling/openmrs/dist/runner.js 799 B
packages/tooling/openmrs/dist/utils/config.js 665 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B
packages/tooling/openmrs/dist/utils/dependencies.js 403 B
packages/tooling/openmrs/dist/utils/helpers.js 393 B
packages/tooling/openmrs/dist/utils/importmap.js 2.79 kB
packages/tooling/openmrs/dist/utils/index.js 370 B
packages/tooling/openmrs/dist/utils/logger.js 234 B
packages/tooling/openmrs/dist/utils/npmConfig.js 854 B
packages/tooling/openmrs/dist/utils/untar.js 648 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B
packages/tooling/webpack-config/dist/index.js 3 kB
packages/tooling/webpack-config/dist/optimize.js 1.79 kB

compressed-size-action

@ibacher
Copy link
Member

ibacher commented May 22, 2023

One small ask here: can we also delete dependencies.ts in esm-app-shell? It's now, thankfully, unneccessary.

@ibacher ibacher changed the title (refactor) Setup esm-form-entry to use webpack module federation (fix) Remove unused SystemJS-related code May 22, 2023
@ibacher ibacher merged commit 990251e into main May 22, 2023
@ibacher ibacher deleted the refactor/webpack-module-federation branch May 22, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants