(test) O3-2936 : add e2e tests for edit and delete vitals and biometrics #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthil-athiban
changed the title
…-chart into test/e2e_for_edit_vitals_and_biometrics
senthil-athiban
changed the title
…-chart into test/e2e_for_edit_vitals_and_biometrics
senthil-athiban
changed the title
|
@senthil-athiban Please fix the merge conflicts. Sorry about the delay with a review. I have requested a review from @kdaud (or @jayasanka-sack if Daud cannot). |
kdaud
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Thanks @senthil-athiban. I've left few comments for you to address.
e2e/specs/biometrics.spec.ts
Outdated
| await expect(biometricsPage.page.getByText(/Edit vitals and biometrics/i)).toBeVisible(); | ||
| }); | ||
|
|
||
| await test.step('And I change the `Weight`', async () => { |
There was a problem hiding this comment.
Suggested change
| await test.step('And I change the `Weight`', async () => { | |
| await test.step('When I change the weight to `70`', async () => { |
There was a problem hiding this comment.
Let's consider revising at least two biometrics.
e2e/specs/vitals.spec.ts
Outdated
| await expect(vitalsPage.page.getByText(/Edit vitals and biometrics/i)).toBeVisible(); | ||
| }); | ||
|
|
||
| await test.step('And I change the `Temperature`', async () => { |
There was a problem hiding this comment.
Suggested change
| await test.step('And I change the `Temperature`', async () => { | |
| await test.step('When I change the temperature to `42`', async () => { |
There was a problem hiding this comment.
Let's consider revising at least two vitals.
|
@senthil-athiban fix the failing build. |
|
Ping @senthil-athiban |
|
@brandones as we have reverted the edit and delete feature for vitals and biometrics, can we close this one.? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
End-to-End tests for editing and deleting vitals.
Related Issue
O3-2936