chore: update checks

opennextjs · Aug 18, 2022 · 398efb1 · 398efb1
1 parent 68710db
commit 398efb1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/packages/runtime/src/helpers/dev.ts b/packages/runtime/src/helpers/dev.ts
@@ -1,14 +1,14 @@
 import { resolve } from 'path'
 
-import { NetlifyPlugin } from '@netlify/build'
+import { OnPreBuild } from '@netlify/build'
 import execa from 'execa'
 import { unlink, existsSync } from 'fs-extra'
 
 import { writeDevEdgeFunction } from './edge'
 import { patchNextFiles } from './files'
 
 // The types haven't been updated yet
-export const onPreDev: NetlifyPlugin['onPreBuild'] = async ({ constants, netlifyConfig }) => {
+export const onPreDev: OnPreBuild = async ({ constants, netlifyConfig }) => {
   // Need to patch the files, because build might not have been run
   await patchNextFiles(resolve(netlifyConfig.build.publish, '..'))
 

diff --git a/packages/runtime/src/index.ts b/packages/runtime/src/index.ts
@@ -31,7 +31,7 @@ import {
   warnForRootRedirects,
 } from './helpers/verification'
 
-const plugin: NetlifyPlugin & { onPreDev?: OnPreBuild; onDev?: OnPreBuild } = {
+const plugin: NetlifyPlugin = {
   async onPreBuild({
     constants,
     netlifyConfig,
@@ -220,7 +220,10 @@ const plugin: NetlifyPlugin & { onPreDev?: OnPreBuild; onDev?: OnPreBuild } = {
   },
 }
 // The types haven't been updated yet
-const nextRuntime = (_inputs, meta: { events?: Set<string> } = {}): NetlifyPlugin & { onPreDev?: OnPreBuild } => {
+const nextRuntime = (
+  _inputs,
+  meta: { events?: Set<string> } = {},
+): NetlifyPlugin & { onPreDev?: NetlifyPlugin['onPreBuild'] } => {
   if (!meta?.events?.has('onPreDev')) {
     return {
       ...plugin,

diff --git a/packages/runtime/src/templates/edge/next-dev.ts b/packages/runtime/src/templates/edge/next-dev.ts
@@ -89,9 +89,11 @@ const exists = async (relativePath: string) => {
 }
 
 const handler = async (req: Request, context: Context) => {
-  // if (!Deno.env.get('NETLIFY_DEV')) {
-  //   return
-  // }
+  if (!Deno.env.get('NETLIFY_DEV')) {
+    // Only run in dev
+    return
+  }
+
   let middleware
   // Dynamic imports and FS operations aren't allowed when deployed,
   // but that's fine because this is only ever used locally.

diff --git a/packages/runtime/src/templates/edge/runtime.ts b/packages/runtime/src/templates/edge/runtime.ts
@@ -46,7 +46,7 @@ globalThis.NFRequestContextMap ||= new Map()
 
 const handler = async (req: Request, context: Context) => {
   if (Deno.env.get('NETLIFY_DEV')) {
-    console.log('is dev')
+    // Don't run in dev
     return
   }
   const url = new URL(req.url)