-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add edge middleware support to ntl dev
#1546
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2404144
feat: add edge middleware support to `ntl dev`
ascorbic 5dd37ba
chore: typo
ascorbic aaac07a
chore: null check for plugin instantiation
ascorbic bc57137
chore: use plugin wrapper
ascorbic e73ea18
Merge branch 'main' into mk/edge-dev
ascorbic bda350d
Merge branch 'main' into mk/edge-dev
ascorbic abaf924
Merge branch 'main' into mk/edge-dev
ascorbic 904bd05
Merge branch 'mk/edge-dev' of github.com:netlify/next-runtime into mk…
ascorbic cce9c0e
chore: refactor
ascorbic 6748bd4
chore: fix test
ascorbic 68710db
Merge branch 'main' into mk/edge-dev
ascorbic 398efb1
chore: update checks
ascorbic 38daf34
chore: use opt-out for edge at build/dev time
ascorbic fc0c68b
chore: make build work
ascorbic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,16 +5,13 @@ import { MiddlewareRequest } from '@netlify/next' | |
|
||
export async function middleware(req: NextRequest) { | ||
let response | ||
const { | ||
nextUrl: { pathname }, | ||
} = req | ||
const { pathname } = req.nextUrl | ||
|
||
const request = new MiddlewareRequest(req) | ||
|
||
if (pathname.startsWith('/static')) { | ||
// Unlike NextResponse.next(), this actually sends the request to the origin | ||
const res = await request.next() | ||
const message = `This was static but has been transformed in ${req.geo.city}` | ||
const message = `This was static but has been transformed in ${req.geo?.city}` | ||
|
||
// Transform the response HTML and props | ||
res.replaceText('p[id=message]', message) | ||
|
@@ -58,6 +55,16 @@ export async function middleware(req: NextRequest) { | |
response.headers.set('x-modified-in-rewrite', 'true') | ||
} | ||
|
||
if (pathname.startsWith('/shows/redirectme')) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redirects were broken, so these are the added tests |
||
const url = req.nextUrl.clone() | ||
url.pathname = '/shows/100' | ||
response = NextResponse.redirect(url) | ||
} | ||
|
||
if (pathname.startsWith('/shows/redirectexternal')) { | ||
response = NextResponse.redirect('http://example.com/') | ||
} | ||
|
||
if (!response) { | ||
response = NextResponse.next() | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirects weren't working, so this is a test for the fix