Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX np.NaN is not available anymore in numpy2.0 #111

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

tomMoral
Copy link
Contributor

Just notived a failure with numpy 2.0.
This is a quick fix for the failure I observed.

@tomMoral
Copy link
Contributor Author

Not sure how to cope with the missing AttributeError: scipy.optimize.optimizehas no attributeMemoizeJac`

@arokem
Copy link
Collaborator

arokem commented Jun 30, 2024

This seems relevant: scipy/scipy#17572 (comment)

@arokem
Copy link
Collaborator

arokem commented Jun 30, 2024

Looks like this works:

from scipy.optimize._optimize import MemoizeJac

@arokem
Copy link
Collaborator

arokem commented Jun 30, 2024

Looks good! Unless anyone objects, I can go ahead and merge it in a couple of days.

@tomMoral
Copy link
Contributor Author

tomMoral commented Jul 1, 2024

Great :)

Note that we saw this failure in the test of our benchmark on logreg l2, where we benchmark copt against other solvers :)
https://github.com/benchopt/benchmark_logreg_l2

It has been a while since we updated the copt solver so if you think we can improve its performances, feel free to contribute updates to the copt solver

@fabianp
Copy link
Member

fabianp commented Jul 4, 2024

thanks all!

@arokem
Copy link
Collaborator

arokem commented Sep 11, 2024

Hey @fabianp : any chance to put out a pypi release (0.9.2?) that includes this fix? Thanks!

@fabianp
Copy link
Member

fabianp commented Sep 27, 2024 via email

@tomMoral tomMoral deleted the FIX_adapt_numpy2.0 branch September 27, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants