Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The role argument of brm_data() is unnecessary #119

Closed
wlandau opened this issue Jul 11, 2024 · 0 comments · Fixed by #120
Closed

The role argument of brm_data() is unnecessary #119

wlandau opened this issue Jul 11, 2024 · 0 comments · Fixed by #120
Assignees

Comments

@wlandau
Copy link
Collaborator

wlandau commented Jul 11, 2024

The purpose of the role argument of brm_data() is to declare whether the outcome variable is raw response (AVAL) or change from baseline (CHG). This matters because brm_marginal_draws() needs to know whether it can compute change from baseline. However, it is possible (and sometimes desirable) to analyze AVAL for datasets that do not even have a baseline value in the discrete time variable. So the question is not whether the outcome is AVAL or CHG, the question is whether the user specifies a baseline value in the reference_time argument. reference_time alone should be enough to decide. We can deprecate the role argument entirely.

@wlandau wlandau self-assigned this Jul 11, 2024
wlandau-lilly pushed a commit that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant