Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Park Improvements #279

Closed
vonnieda opened this issue May 26, 2016 · 1 comment
Closed

Park Improvements #279

vonnieda opened this issue May 26, 2016 · 1 comment
Labels
feature-request

Comments

@vonnieda
Copy link
Member

vonnieda commented May 26, 2016 •
edited
Loading

Originally from #273, some improvements to the Park system are needed:

  • Park should be a method on head rather than being a bunch of copypasted code everywhere. One thing to consider is that this would break the UI which allows parking of XY, C or Z. Maybe the method would take those as booleans.
  • Park should always park at the same location by subtracting the offsets of the object it moves. Due to the driver API we can't just send an absolute coordinate, but we can pre-subtract the head offsets from the default nozzle, for instance, and send that.
@vonnieda vonnieda mentioned this issue May 26, 2016
Closed
@vonnieda vonnieda mentioned this issue Apr 5, 2017
Merged
@vonnieda
Copy link
Member Author

vonnieda commented Apr 5, 2017

@cri-s Do you know of any machines currently using OpenPnP with more than one head?

vonnieda added a commit that referenced this issue Feb 16, 2019
@vonnieda
Merge branch 'develop' into feature/fiducial-transforms
822352f 
* develop: (280 commits)
  Fix #650 by refusing to delete last nozzle.
  Lint
  Fixes #676 by making long lists of actuators wrap.
  Added new variables to GcodeDriver to allow for direction signalling.
  Added XY soft limits.
  * Park XY now always parks the head at the same location, regardless of what tool is selected in   the jog control dropdown. This ensures that if you choose a park location with one tool selected   and then attempt to park with a different tool selected you don't crash the head. This is   primarily a safety improvement. * Z and Rotation have been removed from the park head configuration since these are each specific   to the tool being parked. * Park Z now parks the selected tool at Safe Z instead of the Z entered in the head configuration. * Park Rotation now parks the selected tool's rotation at 0 instead of the Rotation entered in the   head configuration. * Fixes #279
  exposed offsetThreshold via GUI and added to machine.xml set more reasonable default value reverted change that resorts pipeline results by distance to bottom camera updated comments
  fix whitespace
  reduced default offsetThreshold
  fix to have kasa return 0 instead NaN if all measurements are exactly the same (this is true for simulated machine only) added offsetThreshold to be the configurable value - all measured offset locations above are removed from pipelines resultset added some debugging information output
  added plausibility checks/warnings and some automatic error correction if possible to findcircle fixed .toString to reflect the correct angle (index 0 holds the first measurement, which is -180° per default
  Added note about upcoming breaking changes.
  Fix alignment in camera position wizard.
  CameraView snapshot (double click) now uses capture rather than the last frame. This works better when dealing with low FPS cameras.
  Update README.md
  NozzleTip.Calibration.angleIncrement was removed as part of the calibration overhaul recently, but this caused older configs to be unable to load. This adds the property back and nulls it out so that configurations will load and the value will be removed.
  Added new scripting events for nozzle tip load and unload: NozzleTip.Loaded, NozzleTip.Unloaded.
  Move em.
  Move the camera utilities to the util package.
  Add change log help menu item.
  ...

# Conflicts:
#	pom.xml
#	src/main/java/org/openpnp/machine/reference/vision/ReferenceFiducialLocator.java
#	src/main/java/org/openpnp/machine/reference/vision/wizards/ReferenceFiducialLocatorConfigurationWizard.java
#	src/main/java/org/openpnp/model/BoardLocation.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vonnieda