Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Windows Docker file permissions #160

Merged
merged 5 commits into from
Nov 26, 2019

Conversation

carlwilson
Copy link
Member

@carlwilson carlwilson commented Nov 22, 2019

  • use id utility to deduce running process uid and default group id for Docker chown command; and
  • the container is still run in a single invocation with chained commands.

@bitsgalore, you probably don't need to do the PyPi thing for this but if you do I'd suggest a post release.

@carlwilson carlwilson self-assigned this Nov 22, 2019
@carlwilson carlwilson added the bug A product defect that needs fixing label Nov 22, 2019
@carlwilson carlwilson added this to the v1.20-m4 Release milestone Nov 22, 2019
@carlwilson
Copy link
Member Author

carlwilson commented Nov 22, 2019

@bitsgalore, while it's not the reworking of the Docker flow we talked about, it's still a much more elegant solution and should ensure build artefacts are all given the calling users uid as owner and primary group id as group.

@bitsgalore bitsgalore merged commit 46e97df into jpylyzer-2-dev Nov 26, 2019
@bitsgalore bitsgalore deleted the fix/file-permissions branch November 26, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants