FIX: Align messages with draft specification #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new `org.openpreservation.odf.validation.Rule` interface for extended checks; - implemented `org.openpreservation.odf.validation.AbstractRule` class; - implemented `ODF_2` compliance test and reporting; - added `org.openpreservation.odf.validation.Rules` utility class; and - tidied `PackageParserTest` class.
- implemented package `mimetype` entry detection as `ODF_3` rule; - added null archive protection for `org.openpreservation.odf.pkg.OdfPackageImpl` methods; and - added `Rules` method to get `ODF_3`rule.
- implemented rule for extension and MIME type checking; - added `Rules` method for instantiation of rule; and - cleaned up unnecessary exceptions.
- added necessary Package methods to implement digital signature detection; - implemented digital signature detection for ODF_9 in `DigitalSignaturesRule`; and - added method to `Rules` for easy rule instantiation.
- swapped `MAN-1` and `MAN-4` so that the first matches the reporting in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAN-1andMAN-4so that the first matches the reporting in the spec.