Migrate several devices to none/on effects (and breathing mono effect) #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lah7
approved these changes
Jun 19, 2023
|
|
z3ntu
force-pushed
the
next-on
branch
2 times, most recently
from
e4fd418
to
d2c74df
Compare
z3ntu
changed the title
lah7
pushed a commit
to polychromatic/polychromatic
that referenced
this pull request
Jul 11, 2023
Previously we had e.g. setLogoPulsateMono which didn't make much sense because pulsating and breathing is the same effect. Unify the effect under the breath name. See also: openrazer/openrazer#2086 Fixes #443.
Now that the major UIs support this effect, let's update the daemon to use those new methods. And then we can also remove the unused bits from the driver.
A bit of a weird mix between matrix and led_state somehow...
As added in the last commit, add the effect to pylib also.
Move it where it makes more sense, and add a default case to catch faulty uses.
|
Ready now! |
lah7
added a commit
to polychromatic/polychromatic
that referenced
this pull request
Oct 17, 2023
"active" has become "on" openrazer/openrazer#2086
lah7
added a commit
to polychromatic/polychromatic
that referenced
this pull request
Oct 17, 2023
"active" has become "on" openrazer/openrazer#2086
lah7
added a commit
to polychromatic/polychromatic
that referenced
this pull request
Oct 17, 2023
"active" has become "on" openrazer/openrazer#2086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the major UIs support this effect, let's update the daemon to use those new methods.
^^ above commit message is for the future. To be merged when polychromatic and RazerGenie have new releasesOn effect
Breath mono-color effect
CC @lah7