-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ AC console - Show correct meta review when there are multiple #2090
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The logged in AC can see their recommendation in the AC console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the recommendation values that are shown in the SAC and PC consoles? I feel like it's weird/inconsistent to show the recommendations for some papers, but not others even when the meta review is submitted. Right now we only show them if it was posted by the AC:
The AC console does look as expected. But in the case of AAAI where there are multiple invitees to the meta review invitation but only 1 note is expected, I feel it would be confusing to show Submit
to the AC when they actually have no action. For context, Paper 2's meta review was submitted by the SAC:
So I'm not sure how AAAI's workflow fits with these changes. But that's my main concern.
@enrubio pc and sac console would show multiple meta reviews for AC console maybe it can have a new config to decide whether to skip the signature comparison so it would work the case that there are multiple assigned ACs but only one meta review is required |
currently AC console shows the first meta review because it assumes there are only 1 meta review which is not always true.
this pr should add checking of meta review signature so that the AC console shows the meta review of the logged in user (AC)