Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ Edge browser - only show entities associated with parent on initial load #2110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

currently edge browser show items when it has traverse edge, even if it's not related to the parent entity by traverse edge (assignment) or browse edge (affinity score) at all.

this pr should filter out such items on initial load
when user perform search or max quota filtering, such items should still be displayed (refer to #1480 for rationale)

@carlosmondra
Copy link
Member

when user perform search or max quota filtering, such items should still be displayed

Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column?

@xkopenreview
Copy link
Collaborator Author

xkopenreview commented Sep 26, 2024

when user perform search or max quota filtering, such items should still be displayed

Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column?

that's right.
search for a reviewer or using quota reached checkbox

@carlosmondra
Copy link
Member

when user perform search or max quota filtering, such items should still be displayed

Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column?

that's right. search for a reviewer or using quota reached checkbox

So the search is performed on all the edges just using the invitation as the filter, correct?
Is there a way to make this optional for the search? TMLR wants to avoid this from happening, but I understand why it would be a desirable feature for other venues.

@xkopenreview
Copy link
Collaborator Author

when user perform search or max quota filtering, such items should still be displayed

Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column?

that's right. search for a reviewer or using quota reached checkbox

So the search is performed on all the edges just using the invitation as the filter, correct? Is there a way to make this optional for the search? TMLR wants to avoid this from happening, but I understand why it would be a desirable feature for other venues.

i think we can either has some setting in the traverse invitation to denote this or has a new query param to control whether to filter out those entities with no relation with parent

@carlosmondra
Copy link
Member

when user perform search or max quota filtering, such items should still be displayed

Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column?

that's right. search for a reviewer or using quota reached checkbox

So the search is performed on all the edges just using the invitation as the filter, correct? Is there a way to make this optional for the search? TMLR wants to avoid this from happening, but I understand why it would be a desirable feature for other venues.

i think we can either has some setting in the traverse invitation to denote this or has a new query param to control whether to filter out those entities with no relation with parent

I would prefer to have a parameter in the edge browser. @celestemartinez do you have any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants