Skip to content

Commit

Permalink
refactor: OpenRewrite best practices
Browse files Browse the repository at this point in the history
  • Loading branch information
timtebeek and TeamModerne committed Aug 12, 2024
1 parent d0375f6 commit 83572ca
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ public void testJakarta() {
void removedExpressionLanguageTestJakarta_2() {
rewriteRun(
//language=java
java("""
java(
"""
package com.test;
import jakarta.faces.el.VariableResolver;
Expand Down Expand Up @@ -160,7 +161,8 @@ public void testJavax() {
void removedExpressionLanguageTestJavax_2() {
rewriteRun(
//language=java
java("""
java(
"""
package com.test;
import javax.faces.el.VariableResolver;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ public void defaults(RecipeSpec spec) {
@DocumentExample
void removeFinalizerForInflater() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooInflater extends Inflater {
Expand All @@ -59,7 +60,8 @@ public void test() {
@Test
void removeCallsToSelfFinalize() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooBar extends Inflater {
Expand All @@ -80,7 +82,8 @@ public void test() {
@Test
void removeCallsToThisFinalize() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooBar extends Inflater {
Expand All @@ -101,7 +104,8 @@ public void test() {
@Test
void removeWhileKeepingSideEffects() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooBar extends Inflater {
Expand All @@ -123,7 +127,8 @@ public void test() {
@Test
void noChangeWithFinalizeOnObject() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooBar extends Inflater {
Expand All @@ -137,7 +142,8 @@ public void test() {
@Test
void noChangeWithoutFinalizerForInflater() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Inflater;
class FooBar extends Inflater {
Expand All @@ -151,7 +157,8 @@ public void test() {
@Test
void removeFinalizerForDeflater() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Deflater;
class FooBar extends Deflater {
Expand All @@ -174,7 +181,8 @@ public void test() {
@Test
void noChangeWithoutFinalizerForDeflater() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.Deflater;
class FooBar extends Deflater {
Expand All @@ -188,7 +196,8 @@ public void test() {
@Test
void removeFinalizerForZipFile() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.ZipFile;
class FooBar extends ZipFile {
Expand Down Expand Up @@ -217,7 +226,8 @@ public void test() {
@Test
void noChangeWithoutFinalizerForZipFile() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
import java.util.zip.ZipFile;
class FooBar extends ZipFile {
Expand All @@ -234,7 +244,8 @@ public void test() {
@Test
void noChangeWithoutExtends() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
class FooBar {
public void test() {
new Object().finalize();
Expand All @@ -246,7 +257,8 @@ public void test() {
@Test
void noChangeWithoutExtendsOrSelect() {
//language=java
rewriteRun(java("""
rewriteRun(java(
"""
class FooBar {
public void test() {
finalize();
Expand Down

0 comments on commit 83572ca

Please sign in to comment.