[orx-quadtree] add quadtree module #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vechro
reviewed
Feb 26, 2021
| * | ||
| * @param drawer | ||
| */ | ||
| fun draw(drawer: Drawer) { |
There was a problem hiding this comment.
@edwinRNDR do Compositions have the functionality to achieve this? In which case, could a function like this return a Composition instead, without passing around the Drawer?
There was a problem hiding this comment.
It could but it is not as fast as the batch builders are. I don't see a problem with passing around the Drawer (it is pretty much made to be safely passed around)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.