[orx-compositor] BufferMultisample in Layer #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vechro
commented
May 16, 2022
Comment on lines
+219
to
+220
| activeRenderTargetColorBuffer?.destroy() | ||
| activeRenderTargetColorBuffer = colorBuffer(activeRenderTarget.width, activeRenderTarget.height, | ||
| activeRenderTarget.contentScale, type = colorType) |
There was a problem hiding this comment.
I don't actually know what "active" rendertarget means or if there's any semantics associated with it. I'm assuming it can change dimensions so I'm recreating it here if it does so.
with colorbuffer caching
Vechro
force-pushed
the
compositor-multisample
branch
from
5fea790
to
c53f555
Compare
Vechro
commented
May 16, 2022
| @@ -43,7 +43,8 @@ open class Layer internal constructor() { | |||
| var blendFilter: Pair<Filter, Filter.() -> Unit>? = null | |||
| val postFilters: MutableList<Pair<Filter, Filter.() -> Unit>> = mutableListOf() | |||
| var colorType = ColorType.UINT8 | |||
| var accumulation: ColorBuffer? = null | |||
| private var resolvedColorBuffer: ColorBuffer? = null | |||
| private var activeRenderTargetColorBuffer: ColorBuffer? = null | |||
There was a problem hiding this comment.
This could be a lateinit I suppose, I don't know which option is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of Yvee1's work in #204 to address #178.
I need more test cases to verify it works for all cases but it seems to handle the basic composite layers fine.
Also makes layers contentScale aware.