Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid expensive csv checks #732

Merged
merged 2 commits into from
May 9, 2024
Merged

avoid expensive csv checks #732

merged 2 commits into from
May 9, 2024

Conversation

bloodearnest
Copy link
Member

  • Backport fixes from production backfill
  • Reorder the level 4 checks to optimise finalize time.

@bloodearnest
Backport fixes from production backfill
8876da9
@bloodearnest
Reorder the level 4 checks to optimise finalize time.
0496c08 
Now, we check for size first, and don't bother checking for row if its
over the limit. This avoids the length process of counting rows for
large files.
@bloodearnest bloodearnest merged commit 9a18f01 into main May 9, 2024
14 checks passed
@bloodearnest bloodearnest deleted the avoid-expensive-csv-checks branch May 9, 2024 13:11
@bloodearnest bloodearnest mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansd evansd evansd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloodearnest @evansd