Set MAX_DB_WORKER limit in local_run
#743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this is merged and a new PyPI package published we'll need to update the vendored version in Update: now done |
|
I think failures are related to the issue Simon is battling at the moment, see: Once a fix for that is out I'll rebase this PR. |
Merged
bloodearnest
approved these changes
Sep 27, 2024
We allow the user to set the number of concurrent jobs using the `--concurrency` argument and use this to update the worker limit, but we didn't update the database worker limit. The distinction is meaningless for local jobs in any case because these jobs are just generating dummy data, but it meant that jobs ran with less parallelism than expected. It also lead to "Waiting on available database workers" messages appearing in the log output which caused confusion and anxiety.
evansd
force-pushed
the
evansd/local-run-db-workers
branch
from
c2b806a
to
e9be162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow the user to set the number of concurrent jobs using the
--concurrencyargument and use this to update the worker limit, but we didn't update the database worker limit.The distinction is meaningless for local jobs in any case because these jobs are just generating dummy data, but it meant that jobs ran with less parallelism than expected. It also lead to "Waiting on available database workers" messages appearing in the log output which caused confusion and anxiety.