Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Docker-in-Docker configuration #8

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

StevenMaude
Copy link
Contributor

We dropped this for the research-template.

See opensafely/research-template#129.

We dropped this for the research-template.

See opensafely/research-template#129.
@StevenMaude StevenMaude linked an issue Aug 14, 2024 that may be closed by this pull request
@StevenMaude
Copy link
Contributor Author

Tried this out, and #6 is resolved with this change.

@StevenMaude
Copy link
Contributor Author

A screenshot of the Codespaces terminal which shows the regular "Welcome to Codespaces" message, indicating issue 6 is fixed.

@madwort madwort merged commit 7d2fce3 into main Aug 14, 2024
@madwort madwort deleted the steve/update-docker-in-docker-configuration branch August 14, 2024 14:19
@StevenMaude
Copy link
Contributor Author

StevenMaude commented Aug 14, 2024

For the record, I'll note that this change only fixed the problem incidentally.

Having looked more — and for future reference — this is what I think happened:

  • Docker Compose has a v2.29.2 tag, but doesn't currently have a v2.29.2 release.
  • We specified v2 as dockerDashComposeVersion in devcontainer.json.
    • The dev container feature shell script finds the latest v2 GitHub release version via looking at tags, and then tries to download that tag's release.
    • This is what was causing the failures; a v2.29.2 release didn't exist.
  • If the dockerDashComposeVersion isn't specified in the Docker-in-Docker configuration, then the option used in the dev container feature shell script is latest.

That said, it's still better to keep the dev container configuration as close to the research-template as possible (see also #7), and it reduces the amount of configuration here too.

I'd guess we're not really using docker-compose in this repository, so the version set shouldn't matter too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespace configuration error
2 participants